Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore zero properties for MemoryInfo #1531

Merged
merged 4 commits into from
Mar 19, 2022
Merged

Conversation

SimonCropp
Copy link
Contributor

@SimonCropp SimonCropp commented Mar 16, 2022

WriteNumberIfNotZero since on OS that dont implement all props, thos props are stubbed out to zero
unknown

@getsentry getsentry deleted a comment from github-actions bot Mar 16, 2022
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there's some API we can call that will tell us whether GetGCMemoryInfo returns meaningful data or not. I mean: When do we get all zeros/defaults?

src/Sentry/Internal/MemoryInfo.cs Outdated Show resolved Hide resolved
src/Sentry/Internal/MemoryInfo.cs Outdated Show resolved Hide resolved
@getsentry getsentry deleted a comment from codecov-commenter Mar 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2022

Codecov Report

Merging #1531 (9b5fe2f) into main (b26a2fb) will decrease coverage by 1.69%.
The diff coverage is 65.38%.

@@            Coverage Diff             @@
##             main    #1531      +/-   ##
==========================================
- Coverage   84.43%   82.73%   -1.70%     
==========================================
  Files         219      219              
  Lines        7388     7398      +10     
  Branches     1416     1421       +5     
==========================================
- Hits         6238     6121     -117     
- Misses        722      852     +130     
+ Partials      428      425       -3     
Impacted Files Coverage Δ
src/Sentry/Internal/MainSentryEventProcessor.cs 97.34% <ø> (-0.03%) ⬇️
src/Sentry/Internal/Extensions/JsonExtensions.cs 80.00% <40.00%> (-3.75%) ⬇️
src/Sentry/Internal/MemoryInfo.cs 100.00% <100.00%> (ø)
src/Sentry/PlatformAbstractions/FrameworkInfo.cs 0.00% <0.00%> (-100.00%) ⬇️
...ntry/PlatformAbstractions/RegistryKeyExtensions.cs 0.00% <0.00%> (-100.00%) ⬇️
...Sentry/PlatformAbstractions/FrameworkInfo.NetFx.cs 0.00% <0.00%> (-70.43%) ⬇️
...rmAbstractions/NetFxInstallationsEventProcessor.cs 4.54% <0.00%> (-68.19%) ⬇️
...ntry/PlatformAbstractions/FrameworkInstallation.cs 25.00% <0.00%> (-37.50%) ⬇️
...als/DiagnosticSource/SentryDiagnosticSubscriber.cs 60.00% <0.00%> (-36.00%) ⬇️
...ntry/Integrations/NetFxInstallationsIntegration.cs 28.57% <0.00%> (-28.58%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b26a2fb...9b5fe2f. Read the comment docs.

@SimonCropp
Copy link
Contributor Author

@bruno-garcia

I wonder if there's some API we can call that will tell us whether GetGCMemoryInfo returns meaningful data or not. I mean: When do we get all zeros/defaults?

not from my research

@SimonCropp SimonCropp merged commit cf2592b into main Mar 19, 2022
@SimonCropp SimonCropp deleted the ignore-empty-memory-props branch March 19, 2022 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants