Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup diagnostic source #1529

Merged
merged 41 commits into from
Mar 19, 2022
Merged

Cleanup diagnostic source #1529

merged 41 commits into from
Mar 19, 2022

Conversation

SimonCropp
Copy link
Contributor

No description provided.

@getsentry getsentry deleted a comment from codecov-commenter Mar 16, 2022
@getsentry getsentry deleted a comment from github-actions bot Mar 16, 2022
Copy link
Contributor

@mattjohnsonpint mattjohnsonpint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits in comments, but LGTM so far. 👍

@getsentry getsentry deleted a comment from codecov-commenter Mar 17, 2022
@getsentry getsentry deleted a comment from codecov-commenter Mar 17, 2022
@getsentry getsentry deleted a comment from codecov-commenter Mar 17, 2022
@SimonCropp SimonCropp marked this pull request as ready for review March 17, 2022 21:37
@getsentry getsentry deleted a comment from codecov-commenter Mar 17, 2022
@SimonCropp
Copy link
Contributor Author

@mattjohnsonpint i have made a few more changes. can u give this another once over

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2022

Codecov Report

Merging #1529 (27a9071) into main (cf2592b) will increase coverage by 0.01%.
The diff coverage is 79.19%.

@@            Coverage Diff             @@
##             main    #1529      +/-   ##
==========================================
+ Coverage   82.73%   82.75%   +0.01%     
==========================================
  Files         219      219              
  Lines        7398     7418      +20     
  Branches     1421     1418       -3     
==========================================
+ Hits         6121     6139      +18     
- Misses        852      856       +4     
+ Partials      425      423       -2     
Impacted Files Coverage Δ
...rce/Internals/Extensions/KeyValuePairExtensions.cs 63.63% <63.63%> (-11.37%) ⬇️
...als/DiagnosticSource/SentryDiagnosticSubscriber.cs 59.09% <66.66%> (-0.91%) ⬇️
...gnosticSource/SentryOptionsDiagnosticExtensions.cs 66.66% <66.66%> (ø)
...ce/Internals/DiagnosticSource/SentrySqlListener.cs 80.62% <73.33%> (-1.07%) ⬇️
...Internals/DiagnosticSource/SentryEFCoreListener.cs 93.02% <97.36%> (+3.73%) ⬆️
...osticSource/SentryDiagnosticListenerIntegration.cs 100.00% <100.00%> (ø)
src/Sentry/Exceptions/SentryStackFrame.cs 78.02% <0.00%> (+1.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf2592b...27a9071. Read the comment docs.

@SimonCropp SimonCropp merged commit 12553ce into main Mar 19, 2022
@SimonCropp SimonCropp deleted the cleanup-DiagnosticSource branch March 19, 2022 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants