Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new Protocol for DebugImages and AddressMode #1513

Merged
merged 15 commits into from
Mar 30, 2022

Conversation

Swatinem
Copy link
Member

@Swatinem Swatinem commented Mar 8, 2022

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2022

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

- Add new Protocol for DebugImages and AddressMode ([#1513](https://github.com/getsentry/sentry-dotnet/pull/1513))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against f589af9

@bruno-garcia
Copy link
Member

@SimonCropp is this PR just missing the verify snapshots?
@Swatinem is from the native team, could you please give him a hand?

@SimonCropp
Copy link
Contributor

@Swatinem sorry for the hassle. You can read about Verify here https://github.com/VerifyTests/Verify

For now i have accepted the changes in the pending snaphots.

those api changes are configured to autoverify. so if you run all the tests, you should notice those files being updated in your git tooling.

As for getting you setup and more familiar with snapshot testing. lets chat on discord

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2022

Codecov Report

Merging #1513 (122fac6) into main (7604242) will decrease coverage by 0.47%.
The diff coverage is 14.58%.

❗ Current head 122fac6 differs from pull request most recent head aacc33d. Consider uploading reports for the commit aacc33d to get more accurate results

@@            Coverage Diff             @@
##             main    #1513      +/-   ##
==========================================
- Coverage   84.34%   83.87%   -0.48%     
==========================================
  Files         219      220       +1     
  Lines        7423     7435      +12     
  Branches     1417     1426       +9     
==========================================
- Hits         6261     6236      -25     
- Misses        735      764      +29     
- Partials      427      435       +8     
Impacted Files Coverage Δ
src/Sentry/DebugImage.cs 0.00% <0.00%> (ø)
src/Sentry/SentryEvent.cs 90.62% <33.33%> (-4.34%) ⬇️
src/Sentry/Exceptions/SentryStackFrame.cs 77.89% <80.00%> (+0.97%) ⬆️
...als/DiagnosticSource/SentryDiagnosticSubscriber.cs 88.00% <0.00%> (-7.46%) ⬇️
src/Sentry/Internal/Http/RetryAfterHandler.cs 95.83% <0.00%> (-4.17%) ⬇️
...Internals/DiagnosticSource/SentryEFCoreListener.cs 89.28% <0.00%> (-3.74%) ⬇️
src/Sentry/Internal/Http/CachingTransport.cs 79.31% <0.00%> (-2.64%) ⬇️
src/Sentry/Internal/BackgroundWorker.cs 92.02% <0.00%> (-1.45%) ⬇️
...ce/Internals/DiagnosticSource/SentrySqlListener.cs 81.69% <0.00%> (-1.44%) ⬇️
src/Sentry/Internal/MemoryInfo.cs 100.00% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 982f223...aacc33d. Read the comment docs.

src/Sentry/SentryEvent.cs Outdated Show resolved Hide resolved
src/Sentry/Exceptions/SentryDebugImage.cs Outdated Show resolved Hide resolved
src/Sentry/Exceptions/SentryDebugImage.cs Outdated Show resolved Hide resolved
src/Sentry/SentryEvent.cs Outdated Show resolved Hide resolved
@Swatinem Swatinem marked this pull request as ready for review March 10, 2022 14:57
@Swatinem
Copy link
Member Author

[xUnit.net 00:00:17.03]     Sentry.Tests.TaskUnobservedTaskExceptionIntegrationTests.Handle_UnobservedTaskException_CaptureEvent [FAIL]
Error: Assert.True() Failure
Expected: True
Actual:   False
  Failed Sentry.Tests.TaskUnobservedTaskExceptionIntegrationTests.Handle_UnobservedTaskException_CaptureEvent [4 s]
  Error Message:
   Assert.True() Failure
Expected: True
Actual:   False
  Stack Trace:
    at Sentry.Tests.TaskUnobservedTaskExceptionIntegrationTests.Handle_UnobservedTaskException_CaptureEvent () [0x000c2] in <0cb8deca1ea949418add5fbe2e94325a>:0 
  at (wrapper managed-to-native) System.Reflection.RuntimeMethodInfo.InternalInvoke(System.Reflection.RuntimeMethodInfo,object,object[],System.Exception&)
  at System.Reflection.RuntimeMethodInfo.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x0006a] in <533173d24dae460899d2b10975534bb0>:0 

Seems flaky? It used to pass before the merge.

@bruno-garcia
Copy link
Member

It was once before so might be again: #743

@bruno-garcia bruno-garcia changed the title feat: Add new Protocol definitions for DebugImages and AddressMode feat: Add new Protocol for DebugImages and AddressMode Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants