Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose IsSystemModuleName as a public static function. #1493

Merged
merged 4 commits into from
Feb 28, 2022

Conversation

lucas-zimerman
Copy link
Collaborator

#skip-changelog.

I don' believe this function belongs to SentryOptionsExtensions since it's not exactly an extension to SentryOptions so leaving it on SentryStackTraceFactory may be thet best place from what I say.

The goal of this PR is to expose IsSystemModuleName so a proper fix can be implemented for getsentry/sentry-unity#575

@lucas-zimerman lucas-zimerman marked this pull request as ready for review February 25, 2022 19:50
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2022

Codecov Report

Merging #1493 (9d74cca) into main (b5acb72) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1493      +/-   ##
==========================================
- Coverage   84.17%   84.17%   -0.01%     
==========================================
  Files         219      219              
  Lines        7383     7388       +5     
  Branches     1420     1421       +1     
==========================================
+ Hits         6215     6219       +4     
  Misses        732      732              
- Partials      436      437       +1     
Impacted Files Coverage Δ
src/Sentry/Exceptions/SentryStackFrame.cs 76.92% <44.44%> (-4.79%) ⬇️
...rc/Sentry/Extensibility/SentryStackTraceFactory.cs 92.13% <100.00%> (+2.88%) ⬆️
src/Sentry/Internal/BackgroundWorker.cs 93.47% <0.00%> (+1.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5acb72...9d74cca. Read the comment docs.

@SimonCropp
Copy link
Contributor

i pushed a very minor xml doc improvement

@lucas-zimerman
Copy link
Collaborator Author

Looks good for me :)

@lucas-zimerman lucas-zimerman merged commit eb06c0b into main Feb 28, 2022
@lucas-zimerman lucas-zimerman deleted the feat/is-app-module branch February 28, 2022 14:37
@bruno-garcia
Copy link
Member

There's a new public API which doesn't match the PR title and has no changelog entry.
Ideally we'd have user-facing changes in the changelog to help folks updating

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants