Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create CachingTransport dirs in constructor #1432

Merged
merged 9 commits into from
Jan 13, 2022

Conversation

SimonCropp
Copy link
Contributor

fixes #1429

@getsentry getsentry deleted a comment from github-actions bot Jan 11, 2022
@getsentry getsentry deleted a comment from github-actions bot Jan 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2022

Codecov Report

Merging #1432 (547c127) into main (6f7d05c) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1432      +/-   ##
==========================================
- Coverage   82.78%   82.77%   -0.01%     
==========================================
  Files         219      219              
  Lines        7350     7346       -4     
  Branches     1409     1409              
==========================================
- Hits         6085     6081       -4     
  Misses        838      838              
  Partials      427      427              
Impacted Files Coverage Δ
src/Sentry/Internal/Http/CachingTransport.cs 85.43% <100.00%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f7d05c...547c127. Read the comment docs.

@SimonCropp SimonCropp enabled auto-merge (squash) January 13, 2022 21:21
@SimonCropp SimonCropp merged commit 4f304c1 into main Jan 13, 2022
@SimonCropp SimonCropp deleted the create-CachingTransport-dirs-in-constructor branch January 13, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Perform a Dir exists check in CachingTransport.GetCacheFilePaths
4 participants