Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EF Core garbage collected messages and ordering. #1368

Merged
merged 7 commits into from
Dec 5, 2021

Conversation

lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented Dec 2, 2021

  • Don't show the message the span was garbage collected when it wasn't.
  • Fix spans grouping (connection/query compiler spans being created on the main transaction and execution spans being created to parent span)

@lucas-zimerman lucas-zimerman added Bug Something isn't working DiagnosticSource labels Dec 2, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2021

Codecov Report

Merging #1368 (7986548) into main (1605e97) will increase coverage by 1.39%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1368      +/-   ##
==========================================
+ Coverage   81.26%   82.66%   +1.39%     
==========================================
  Files         215      215              
  Lines        7142     7146       +4     
  Branches     1407     1408       +1     
==========================================
+ Hits         5804     5907     +103     
+ Misses        913      805     -108     
- Partials      425      434       +9     
Impacted Files Coverage Δ
...Internals/DiagnosticSource/SentryEFCoreListener.cs 89.28% <83.33%> (+0.53%) ⬆️
src/Sentry/Internal/AppDomainAdapter.cs 66.66% <0.00%> (ø)
src/Sentry/PlatformAbstractions/RuntimeInfo.cs 58.62% <0.00%> (+5.17%) ⬆️
...ntry/Integrations/NetFxInstallationsIntegration.cs 57.14% <0.00%> (+28.57%) ⬆️
...ntry/PlatformAbstractions/FrameworkInstallation.cs 62.50% <0.00%> (+37.50%) ⬆️
...rmAbstractions/NetFxInstallationsEventProcessor.cs 72.72% <0.00%> (+68.18%) ⬆️
...Sentry/PlatformAbstractions/FrameworkInfo.NetFx.cs 70.42% <0.00%> (+70.42%) ⬆️
src/Sentry/PlatformAbstractions/FrameworkInfo.cs 100.00% <0.00%> (+100.00%) ⬆️
...ntry/PlatformAbstractions/RegistryKeyExtensions.cs 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1605e97...7986548. Read the comment docs.

@lucas-zimerman lucas-zimerman marked this pull request as ready for review December 2, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working DiagnosticSource
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants