From 8b2a7796e645ee59a2ed886b6f76bbaf011ec483 Mon Sep 17 00:00:00 2001 From: Josh DeGraw Date: Mon, 8 Nov 2021 16:04:12 -0700 Subject: [PATCH 01/12] Update X-Sentry-Auth header to include correct sdk name and version --- src/Sentry/Internal/Http/HttpTransport.cs | 25 +++++++++++++------ .../Internals/Http/HttpTransportTests.cs | 20 +++++++++++++++ 2 files changed, 38 insertions(+), 7 deletions(-) diff --git a/src/Sentry/Internal/Http/HttpTransport.cs b/src/Sentry/Internal/Http/HttpTransport.cs index 2693040315..f79082767a 100644 --- a/src/Sentry/Internal/Http/HttpTransport.cs +++ b/src/Sentry/Internal/Http/HttpTransport.cs @@ -5,6 +5,7 @@ using System.Linq; using System.Net; using System.Net.Http; +using System.Text; using System.Threading; using System.Threading.Tasks; using Sentry.Extensibility; @@ -259,6 +260,22 @@ private async Task HandleFailureAsync( } } + private string BuildAuthHeader(Dsn dsn) + { + var builder = new StringBuilder(100) + .AppendFormat("Sentry") + .AppendFormat(" sentry_key={0}", dsn.PublicKey) + .AppendFormat(", sentry_version={0}", _options.SentryVersion) + .AppendFormat(", sentry_client={0}/{1}", SdkVersion.Instance.Name, SdkVersion.Instance.Version) + .AppendFormat(", sentry_timestamp={0}", _clock.GetUtcNow().ToUnixTimeSeconds()); + + if (dsn.SecretKey is { } secretKey) + { + builder.AppendFormat(", sentry_secret={0}", secretKey); + } + return builder.ToString(); + } + internal HttpRequestMessage CreateRequest(Envelope envelope) { if (string.IsNullOrWhiteSpace(_options.Dsn)) @@ -267,13 +284,7 @@ internal HttpRequestMessage CreateRequest(Envelope envelope) } var dsn = Dsn.Parse(_options.Dsn); - - var authHeader = - $"Sentry sentry_version={_options.SentryVersion}," + - $"sentry_client={_options.ClientVersion}," + - $"sentry_key={dsn.PublicKey}," + - (dsn.SecretKey is { } secretKey ? $"sentry_secret={secretKey}," : null) + - $"sentry_timestamp={_clock.GetUtcNow().ToUnixTimeSeconds()}"; + var authHeader = BuildAuthHeader(dsn); return new HttpRequestMessage { diff --git a/test/Sentry.Tests/Internals/Http/HttpTransportTests.cs b/test/Sentry.Tests/Internals/Http/HttpTransportTests.cs index dba3c657c4..e424657795 100644 --- a/test/Sentry.Tests/Internals/Http/HttpTransportTests.cs +++ b/test/Sentry.Tests/Internals/Http/HttpTransportTests.cs @@ -4,6 +4,7 @@ using System.Linq; using System.Net; using System.Net.Http; +using System.Text.RegularExpressions; using System.Threading; using System.Threading.Tasks; using FluentAssertions; @@ -490,6 +491,25 @@ public void CreateRequest_AuthHeader_IsSet() authHeader.Should().NotBeNullOrWhiteSpace(); } + [Fact] + public void CreateRequest_AuthHeader_IncludesVersion() + { + // Arrange + var httpTransport = new HttpTransport( + new SentryOptions { Dsn = DsnSamples.ValidDsnWithSecret }, + new HttpClient()); + + var envelope = Envelope.FromEvent(new SentryEvent()); + + // Act + using var request = httpTransport.CreateRequest(envelope); + var authHeader = request.Headers.GetValues("X-Sentry-Auth").FirstOrDefault(); + + // Assert + var versionString = Regex.Match(authHeader, @"sentry_client=(\S+),").Groups[1].Value; + versionString.Should().Be($"{SdkVersion.Instance.Name}/{SdkVersion.Instance.Version}"); + } + [Fact] public void CreateRequest_RequestMethod_Post() { From 0b732f459a1740607aec6185d7b5917c42859e7f Mon Sep 17 00:00:00 2001 From: Josh DeGraw Date: Mon, 8 Nov 2021 16:09:08 -0700 Subject: [PATCH 02/12] Update changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 13eee8b60f..407732ff5a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ ### Fixes - Finish unfinished Spans on Transaction completion ([#1296](https://github.com/getsentry/sentry-dotnet/pull/1296)) +- Update X-Sentry-Auth header to include correct sdk name and version ([#1318](https://github.com/getsentry/sentry-dotnet/pull/1318) ## 3.12.0-alpha.1 From fe0d770201f9d737c71c59197e4778cc7b8fed4f Mon Sep 17 00:00:00 2001 From: Josh DeGraw Date: Mon, 8 Nov 2021 16:33:53 -0700 Subject: [PATCH 03/12] Revert, simplify auth header creation change --- src/Sentry/Internal/Http/HttpTransport.cs | 24 +++++++---------------- 1 file changed, 7 insertions(+), 17 deletions(-) diff --git a/src/Sentry/Internal/Http/HttpTransport.cs b/src/Sentry/Internal/Http/HttpTransport.cs index f79082767a..64db3a40f8 100644 --- a/src/Sentry/Internal/Http/HttpTransport.cs +++ b/src/Sentry/Internal/Http/HttpTransport.cs @@ -260,22 +260,6 @@ private async Task HandleFailureAsync( } } - private string BuildAuthHeader(Dsn dsn) - { - var builder = new StringBuilder(100) - .AppendFormat("Sentry") - .AppendFormat(" sentry_key={0}", dsn.PublicKey) - .AppendFormat(", sentry_version={0}", _options.SentryVersion) - .AppendFormat(", sentry_client={0}/{1}", SdkVersion.Instance.Name, SdkVersion.Instance.Version) - .AppendFormat(", sentry_timestamp={0}", _clock.GetUtcNow().ToUnixTimeSeconds()); - - if (dsn.SecretKey is { } secretKey) - { - builder.AppendFormat(", sentry_secret={0}", secretKey); - } - return builder.ToString(); - } - internal HttpRequestMessage CreateRequest(Envelope envelope) { if (string.IsNullOrWhiteSpace(_options.Dsn)) @@ -284,7 +268,13 @@ internal HttpRequestMessage CreateRequest(Envelope envelope) } var dsn = Dsn.Parse(_options.Dsn); - var authHeader = BuildAuthHeader(dsn); + var authHeader = + $"Sentry sentry_version={_options.SentryVersion}," + + $"sentry_client={SdkVersion.Instance.Name}/{SdkVersion.Instance.Version}," + + $"sentry_key={dsn.PublicKey}," + + (dsn.SecretKey is { } secretKey ? $"sentry_secret={secretKey}," : null) + + $"sentry_timestamp={_clock.GetUtcNow().ToUnixTimeSeconds()}"; + return new HttpRequestMessage { From 15e17e0a6d6bf681d7152f9138d05aa1909db764 Mon Sep 17 00:00:00 2001 From: Josh DeGraw Date: Mon, 8 Nov 2021 16:35:50 -0700 Subject: [PATCH 04/12] Whitespace change --- src/Sentry/Internal/Http/HttpTransport.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/Sentry/Internal/Http/HttpTransport.cs b/src/Sentry/Internal/Http/HttpTransport.cs index 64db3a40f8..33a2c47599 100644 --- a/src/Sentry/Internal/Http/HttpTransport.cs +++ b/src/Sentry/Internal/Http/HttpTransport.cs @@ -275,7 +275,6 @@ internal HttpRequestMessage CreateRequest(Envelope envelope) (dsn.SecretKey is { } secretKey ? $"sentry_secret={secretKey}," : null) + $"sentry_timestamp={_clock.GetUtcNow().ToUnixTimeSeconds()}"; - return new HttpRequestMessage { RequestUri = dsn.GetEnvelopeEndpointUri(), From efc3f5239fdde52aa7848a0e44ec9bfff192c947 Mon Sep 17 00:00:00 2001 From: Josh DeGraw Date: Tue, 9 Nov 2021 13:10:48 -0700 Subject: [PATCH 05/12] Cleanup, fix missing namespace --- src/Sentry/Internal/Http/HttpTransport.cs | 1 - test/Sentry.Tests/Internals/Http/HttpTransportTests.cs | 3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Sentry/Internal/Http/HttpTransport.cs b/src/Sentry/Internal/Http/HttpTransport.cs index 33a2c47599..f635bbd01a 100644 --- a/src/Sentry/Internal/Http/HttpTransport.cs +++ b/src/Sentry/Internal/Http/HttpTransport.cs @@ -5,7 +5,6 @@ using System.Linq; using System.Net; using System.Net.Http; -using System.Text; using System.Threading; using System.Threading.Tasks; using Sentry.Extensibility; diff --git a/test/Sentry.Tests/Internals/Http/HttpTransportTests.cs b/test/Sentry.Tests/Internals/Http/HttpTransportTests.cs index 2c6334d1da..b228bfc467 100644 --- a/test/Sentry.Tests/Internals/Http/HttpTransportTests.cs +++ b/test/Sentry.Tests/Internals/Http/HttpTransportTests.cs @@ -3,6 +3,7 @@ using Sentry.Internal.Http; using Sentry.Testing; using Sentry.Tests.Helpers; +using System.Text.RegularExpressions; namespace Sentry.Tests.Internals.Http; @@ -495,7 +496,7 @@ public void CreateRequest_AuthHeader_IncludesVersion() // Assert var versionString = Regex.Match(authHeader, @"sentry_client=(\S+),").Groups[1].Value; - Assert.True(versionString.Contains($"{SdkVersion.Instance.Name}/{SdkVersion.Instance.Version}")); + Assert.Contains(versionString, $"{SdkVersion.Instance.Name}/{SdkVersion.Instance.Version}"); } [Fact] From 11f72db5a2165d4b549b6a7d81b964f4eaac9957 Mon Sep 17 00:00:00 2001 From: Sentry Github Bot Date: Tue, 9 Nov 2021 20:13:43 +0000 Subject: [PATCH 06/12] Format code --- test/Sentry.Tests/Internals/Http/HttpTransportTests.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/Sentry.Tests/Internals/Http/HttpTransportTests.cs b/test/Sentry.Tests/Internals/Http/HttpTransportTests.cs index b228bfc467..08930b945c 100644 --- a/test/Sentry.Tests/Internals/Http/HttpTransportTests.cs +++ b/test/Sentry.Tests/Internals/Http/HttpTransportTests.cs @@ -1,9 +1,9 @@ using System.Net; using System.Net.Http; +using System.Text.RegularExpressions; using Sentry.Internal.Http; using Sentry.Testing; using Sentry.Tests.Helpers; -using System.Text.RegularExpressions; namespace Sentry.Tests.Internals.Http; From 9614ec5ccd03e80f2b1b87cd5fe9c4da72ae4cec Mon Sep 17 00:00:00 2001 From: Lucas Zimerman Fraulob Date: Tue, 23 Nov 2021 16:51:02 -0300 Subject: [PATCH 07/12] fix test. --- CHANGELOG.md | 2 +- .../ApiApprovalTests.Run.DotNet3_1.verified.txt | 1 - .../ApiApprovalTests.Run.DotNet5_0.verified.txt | 1 - .../ApiApprovalTests.Run.DotNet6_0.verified.txt | 1 - test/Sentry.Tests/ApiApprovalTests.Run.DotNet2_1.verified.txt | 1 - test/Sentry.Tests/ApiApprovalTests.Run.DotNet3_0.verified.txt | 1 - test/Sentry.Tests/ApiApprovalTests.Run.DotNet3_1.verified.txt | 1 - test/Sentry.Tests/ApiApprovalTests.Run.DotNet5_0.verified.txt | 1 - test/Sentry.Tests/ApiApprovalTests.Run.DotNet6_0.verified.txt | 1 - test/Sentry.Tests/Internals/Http/HttpTransportTests.cs | 2 +- 10 files changed, 2 insertions(+), 10 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8fc08f5a09..2997301f50 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,7 +10,7 @@ - Avoid using the same connection Span for the same ConnectionId ([#1317](https://github.com/getsentry/sentry-dotnet/pull/1317)) - Finish unfinished Spans on Transaction completion ([#1296](https://github.com/getsentry/sentry-dotnet/pull/1296)) -- Update X-Sentry-Auth header to include correct sdk name and version ([#1318](https://github.com/getsentry/sentry-dotnet/pull/1318) +- Update X-Sentry-Auth header to include correct sdk name and version ([#1333](https://github.com/getsentry/sentry-dotnet/pull/1318) ## 3.12.0-alpha.1 diff --git a/test/Sentry.DiagnosticSource.Tests/ApiApprovalTests.Run.DotNet3_1.verified.txt b/test/Sentry.DiagnosticSource.Tests/ApiApprovalTests.Run.DotNet3_1.verified.txt index a9c316d813..0c5df0939a 100644 --- a/test/Sentry.DiagnosticSource.Tests/ApiApprovalTests.Run.DotNet3_1.verified.txt +++ b/test/Sentry.DiagnosticSource.Tests/ApiApprovalTests.Run.DotNet3_1.verified.txt @@ -379,7 +379,6 @@ namespace Sentry public void WriteTo(System.Text.Json.Utf8JsonWriter writer) { } public static Sentry.SentryEvent FromJson(System.Text.Json.JsonElement json) { } } - public static class SentryEventExtensions { } public class SentryHttpMessageHandler : System.Net.Http.DelegatingHandler { public SentryHttpMessageHandler() { } diff --git a/test/Sentry.DiagnosticSource.Tests/ApiApprovalTests.Run.DotNet5_0.verified.txt b/test/Sentry.DiagnosticSource.Tests/ApiApprovalTests.Run.DotNet5_0.verified.txt index fde187b244..6afd79c6db 100644 --- a/test/Sentry.DiagnosticSource.Tests/ApiApprovalTests.Run.DotNet5_0.verified.txt +++ b/test/Sentry.DiagnosticSource.Tests/ApiApprovalTests.Run.DotNet5_0.verified.txt @@ -379,7 +379,6 @@ namespace Sentry public void WriteTo(System.Text.Json.Utf8JsonWriter writer) { } public static Sentry.SentryEvent FromJson(System.Text.Json.JsonElement json) { } } - public static class SentryEventExtensions { } public class SentryHttpMessageHandler : System.Net.Http.DelegatingHandler { public SentryHttpMessageHandler() { } diff --git a/test/Sentry.DiagnosticSource.Tests/ApiApprovalTests.Run.DotNet6_0.verified.txt b/test/Sentry.DiagnosticSource.Tests/ApiApprovalTests.Run.DotNet6_0.verified.txt index 95fa8c58dc..94b1d7e2b1 100644 --- a/test/Sentry.DiagnosticSource.Tests/ApiApprovalTests.Run.DotNet6_0.verified.txt +++ b/test/Sentry.DiagnosticSource.Tests/ApiApprovalTests.Run.DotNet6_0.verified.txt @@ -379,7 +379,6 @@ namespace Sentry public void WriteTo(System.Text.Json.Utf8JsonWriter writer) { } public static Sentry.SentryEvent FromJson(System.Text.Json.JsonElement json) { } } - public static class SentryEventExtensions { } public class SentryHttpMessageHandler : System.Net.Http.DelegatingHandler { public SentryHttpMessageHandler() { } diff --git a/test/Sentry.Tests/ApiApprovalTests.Run.DotNet2_1.verified.txt b/test/Sentry.Tests/ApiApprovalTests.Run.DotNet2_1.verified.txt index 4b75edce1e..e5c767e2f7 100644 --- a/test/Sentry.Tests/ApiApprovalTests.Run.DotNet2_1.verified.txt +++ b/test/Sentry.Tests/ApiApprovalTests.Run.DotNet2_1.verified.txt @@ -379,7 +379,6 @@ namespace Sentry public void WriteTo(System.Text.Json.Utf8JsonWriter writer) { } public static Sentry.SentryEvent FromJson(System.Text.Json.JsonElement json) { } } - public static class SentryEventExtensions { } public class SentryHttpMessageHandler : System.Net.Http.DelegatingHandler { public SentryHttpMessageHandler() { } diff --git a/test/Sentry.Tests/ApiApprovalTests.Run.DotNet3_0.verified.txt b/test/Sentry.Tests/ApiApprovalTests.Run.DotNet3_0.verified.txt index 85d98cf190..0f5fcc9efc 100644 --- a/test/Sentry.Tests/ApiApprovalTests.Run.DotNet3_0.verified.txt +++ b/test/Sentry.Tests/ApiApprovalTests.Run.DotNet3_0.verified.txt @@ -379,7 +379,6 @@ namespace Sentry public void WriteTo(System.Text.Json.Utf8JsonWriter writer) { } public static Sentry.SentryEvent FromJson(System.Text.Json.JsonElement json) { } } - public static class SentryEventExtensions { } public class SentryHttpMessageHandler : System.Net.Http.DelegatingHandler { public SentryHttpMessageHandler() { } diff --git a/test/Sentry.Tests/ApiApprovalTests.Run.DotNet3_1.verified.txt b/test/Sentry.Tests/ApiApprovalTests.Run.DotNet3_1.verified.txt index a9c316d813..0c5df0939a 100644 --- a/test/Sentry.Tests/ApiApprovalTests.Run.DotNet3_1.verified.txt +++ b/test/Sentry.Tests/ApiApprovalTests.Run.DotNet3_1.verified.txt @@ -379,7 +379,6 @@ namespace Sentry public void WriteTo(System.Text.Json.Utf8JsonWriter writer) { } public static Sentry.SentryEvent FromJson(System.Text.Json.JsonElement json) { } } - public static class SentryEventExtensions { } public class SentryHttpMessageHandler : System.Net.Http.DelegatingHandler { public SentryHttpMessageHandler() { } diff --git a/test/Sentry.Tests/ApiApprovalTests.Run.DotNet5_0.verified.txt b/test/Sentry.Tests/ApiApprovalTests.Run.DotNet5_0.verified.txt index fde187b244..6afd79c6db 100644 --- a/test/Sentry.Tests/ApiApprovalTests.Run.DotNet5_0.verified.txt +++ b/test/Sentry.Tests/ApiApprovalTests.Run.DotNet5_0.verified.txt @@ -379,7 +379,6 @@ namespace Sentry public void WriteTo(System.Text.Json.Utf8JsonWriter writer) { } public static Sentry.SentryEvent FromJson(System.Text.Json.JsonElement json) { } } - public static class SentryEventExtensions { } public class SentryHttpMessageHandler : System.Net.Http.DelegatingHandler { public SentryHttpMessageHandler() { } diff --git a/test/Sentry.Tests/ApiApprovalTests.Run.DotNet6_0.verified.txt b/test/Sentry.Tests/ApiApprovalTests.Run.DotNet6_0.verified.txt index 95fa8c58dc..94b1d7e2b1 100644 --- a/test/Sentry.Tests/ApiApprovalTests.Run.DotNet6_0.verified.txt +++ b/test/Sentry.Tests/ApiApprovalTests.Run.DotNet6_0.verified.txt @@ -379,7 +379,6 @@ namespace Sentry public void WriteTo(System.Text.Json.Utf8JsonWriter writer) { } public static Sentry.SentryEvent FromJson(System.Text.Json.JsonElement json) { } } - public static class SentryEventExtensions { } public class SentryHttpMessageHandler : System.Net.Http.DelegatingHandler { public SentryHttpMessageHandler() { } diff --git a/test/Sentry.Tests/Internals/Http/HttpTransportTests.cs b/test/Sentry.Tests/Internals/Http/HttpTransportTests.cs index 08930b945c..ac69c4ad55 100644 --- a/test/Sentry.Tests/Internals/Http/HttpTransportTests.cs +++ b/test/Sentry.Tests/Internals/Http/HttpTransportTests.cs @@ -495,7 +495,7 @@ public void CreateRequest_AuthHeader_IncludesVersion() var authHeader = request.Headers.GetValues("X-Sentry-Auth").FirstOrDefault(); // Assert - var versionString = Regex.Match(authHeader, @"sentry_client=(\S+),").Groups[1].Value; + var versionString = Regex.Match(authHeader, @"sentry_client=(\S+),sentry_key").Groups[1].Value; Assert.Contains(versionString, $"{SdkVersion.Instance.Name}/{SdkVersion.Instance.Version}"); } From 9457cb09c48294eceb1d1e137d0e855bbf8afbc4 Mon Sep 17 00:00:00 2001 From: Lucas Zimerman Fraulob Date: Tue, 23 Nov 2021 16:54:46 -0300 Subject: [PATCH 08/12] fix changelog. --- CHANGELOG.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4d9c90d852..70845c15fc 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,11 @@ # Changelog +## Unreleased + +### Fixes + +- Update X-Sentry-Auth header to include correct sdk name and version ([#1333](https://github.com/getsentry/sentry-dotnet/pull/1318) + ## 3.12.0 ### Features @@ -10,7 +16,6 @@ - Avoid using the same connection Span for the same ConnectionId ([#1317](https://github.com/getsentry/sentry-dotnet/pull/1317)) - Finish unfinished Spans on Transaction completion ([#1296](https://github.com/getsentry/sentry-dotnet/pull/1296)) -- Update X-Sentry-Auth header to include correct sdk name and version ([#1333](https://github.com/getsentry/sentry-dotnet/pull/1318) ## 3.12.0-alpha.1 From b5d9c6ea49ff1ada88749a902fbd8bc423b482bd Mon Sep 17 00:00:00 2001 From: Lucas Zimerman Fraulob Date: Tue, 23 Nov 2021 16:57:56 -0300 Subject: [PATCH 09/12] Test --- CHANGELOG.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 70845c15fc..507aebce9e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,11 +1,11 @@ # Changelog -## Unreleased - -### Fixes - -- Update X-Sentry-Auth header to include correct sdk name and version ([#1333](https://github.com/getsentry/sentry-dotnet/pull/1318) - +## Unreleased + +### Fixes + +- Update X-Sentry-Auth header to include correct sdk name and version ([#1333](https://github.com/ getsentry/sentry-dotnet/pull/1318) + ## 3.12.0 ### Features From e8d629746a221044c694cc1484911a95ed142764 Mon Sep 17 00:00:00 2001 From: Lucas Zimerman Fraulob Date: Tue, 23 Nov 2021 16:59:01 -0300 Subject: [PATCH 10/12] Remove white spaces --- CHANGELOG.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 507aebce9e..70845c15fc 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,11 +1,11 @@ # Changelog -## Unreleased - -### Fixes - -- Update X-Sentry-Auth header to include correct sdk name and version ([#1333](https://github.com/ getsentry/sentry-dotnet/pull/1318) - +## Unreleased + +### Fixes + +- Update X-Sentry-Auth header to include correct sdk name and version ([#1333](https://github.com/getsentry/sentry-dotnet/pull/1318) + ## 3.12.0 ### Features From fd40752302eaaf685cc7bd56a96e83656ea6496a Mon Sep 17 00:00:00 2001 From: Lucas Zimerman Fraulob Date: Tue, 23 Nov 2021 16:59:18 -0300 Subject: [PATCH 11/12] Fix correct PR number --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 70845c15fc..37dd0c0702 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,7 +4,7 @@ ### Fixes -- Update X-Sentry-Auth header to include correct sdk name and version ([#1333](https://github.com/getsentry/sentry-dotnet/pull/1318) +- Update X-Sentry-Auth header to include correct sdk name and version ([#1333](https://github.com/getsentry/sentry-dotnet/pull/1333) ## 3.12.0 From b2d4553c3ab34650157f4117abc79779d705c11c Mon Sep 17 00:00:00 2001 From: LucasZF Date: Tue, 23 Nov 2021 17:13:22 -0300 Subject: [PATCH 12/12] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 37dd0c0702..b2bc655d6d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,7 +4,7 @@ ### Fixes -- Update X-Sentry-Auth header to include correct sdk name and version ([#1333](https://github.com/getsentry/sentry-dotnet/pull/1333) +- Update X-Sentry-Auth header to include correct sdk name and version ([#1333](https://github.com/getsentry/sentry-dotnet/pull/1333)) ## 3.12.0