Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update X-Sentry-Auth header to include correct sdk name and version #1333

Merged
merged 18 commits into from
Nov 24, 2021

Conversation

lucas-zimerman
Copy link
Collaborator

Closes #1285

@lucas-zimerman lucas-zimerman marked this pull request as ready for review November 23, 2021 19:52
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2021

Codecov Report

Merging #1333 (fd40752) into main (a267bef) will not change coverage.
The diff coverage is 100.00%.

❗ Current head fd40752 differs from pull request most recent head b2d4553. Consider uploading reports for the commit b2d4553 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1333   +/-   ##
=======================================
  Coverage   82.61%   82.61%           
=======================================
  Files         215      215           
  Lines        7146     7146           
  Branches     1406     1406           
=======================================
  Hits         5904     5904           
  Misses        808      808           
  Partials      434      434           
Impacted Files Coverage Δ
src/Sentry/Internal/Http/HttpTransport.cs 94.89% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a267bef...b2d4553. Read the comment docs.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize the api diff doesn't belong here but since it brings it to what it currently represents no reason to leave out

@lucas-zimerman lucas-zimerman enabled auto-merge (squash) November 24, 2021 12:37
@lucas-zimerman lucas-zimerman merged commit 3d186db into main Nov 24, 2021
@lucas-zimerman lucas-zimerman deleted the fix/sdk-name-client branch November 24, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent reporting of SDK information
5 participants