Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle exception from crashedLastRun callback #1328

Merged
merged 7 commits into from
Feb 3, 2022

Conversation

bruno-garcia
Copy link
Member

@bruno-garcia bruno-garcia commented Nov 10, 2021

  • Add a test that verifies the event is captured even if the callback throws

@bruno-garcia bruno-garcia marked this pull request as draft November 10, 2021 21:57
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2022

Codecov Report

Merging #1328 (3073358) into main (3827b35) will decrease coverage by 1.77%.
The diff coverage is 100.00%.

❗ Current head 3073358 differs from pull request most recent head 5a1c9e0. Consider uploading reports for the commit 5a1c9e0 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1328      +/-   ##
==========================================
- Coverage   84.22%   82.45%   -1.78%     
==========================================
  Files         219      219              
  Lines        7380     7386       +6     
  Branches     1416     1417       +1     
==========================================
- Hits         6216     6090     -126     
- Misses        728      869     +141     
+ Partials      436      427       -9     
Impacted Files Coverage Δ
src/Sentry/GlobalSessionManager.cs 78.07% <100.00%> (+0.59%) ⬆️
src/Sentry/PlatformAbstractions/FrameworkInfo.cs 0.00% <0.00%> (-100.00%) ⬇️
...ntry/PlatformAbstractions/RegistryKeyExtensions.cs 0.00% <0.00%> (-100.00%) ⬇️
...Sentry/PlatformAbstractions/FrameworkInfo.NetFx.cs 0.00% <0.00%> (-70.43%) ⬇️
...rmAbstractions/NetFxInstallationsEventProcessor.cs 4.54% <0.00%> (-68.19%) ⬇️
.../Sentry.AspNetCore.Grpc/SentryBuilderExtensions.cs 0.00% <0.00%> (-43.75%) ⬇️
...ntry/PlatformAbstractions/FrameworkInstallation.cs 25.00% <0.00%> (-37.50%) ⬇️
...rc/Sentry.AspNetCore.Grpc/SentryGrpcInterceptor.cs 0.00% <0.00%> (-28.75%) ⬇️
...ntry/Integrations/NetFxInstallationsIntegration.cs 28.57% <0.00%> (-28.58%) ⬇️
src/Sentry/PlatformAbstractions/RuntimeInfo.cs 53.44% <0.00%> (-5.18%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3827b35...5a1c9e0. Read the comment docs.

@bruno-garcia bruno-garcia marked this pull request as ready for review January 14, 2022 18:57
@lucas-zimerman
Copy link
Collaborator

Just to be sure:
Add a test that verifies the event is captured even if the callback throws
you wanna be sure that sessions are captured or events?

@bruno-garcia
Copy link
Member Author

Just to be sure: Add a test that verifies the event is captured even if the callback throws you wanna be sure that sessions are captured or events?

Both actually

@bruno-garcia bruno-garcia merged commit cd7991c into main Feb 3, 2022
@bruno-garcia bruno-garcia deleted the fix/handle-callback-error branch February 3, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants