Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Enhance GCP Integraction. #1286

Merged
merged 9 commits into from
Oct 29, 2021
Merged

Feat: Enhance GCP Integraction. #1286

merged 9 commits into from
Oct 29, 2021

Conversation

lucas-zimerman
Copy link
Collaborator

This PR brings two new sets of features:

  • Performance monitoring for Google Cloud Functions.
  • Correct setup of Release version with the GCP revision number.

In addition, the GCP sample got the Tracing Sample rate to 1.0.

NOTE: Both Transaction names and revision numbers will only be set on Google's environment and not locally.

@lucas-zimerman
Copy link
Collaborator Author

@SimonCropp This PR will have some changes into public fields, what's the best approach for updating the public fields check?

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2021

Codecov Report

Merging #1286 (62df16d) into main (aa6a149) will increase coverage by 0.14%.
The diff coverage is 96.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1286      +/-   ##
==========================================
+ Coverage   81.69%   81.84%   +0.14%     
==========================================
  Files         212      212              
  Lines        7047     7076      +29     
  Branches     1393     1397       +4     
==========================================
+ Hits         5757     5791      +34     
+ Misses        848      845       -3     
+ Partials      442      440       -2     
Impacted Files Coverage Δ
src/Sentry.Google.Cloud.Functions/SentryStartup.cs 98.14% <96.15%> (-1.86%) ⬇️
...try.AspNetCore/Extensions/HttpContextExtensions.cs 83.33% <100.00%> (+1.11%) ⬆️
src/Sentry/Internal/Hub.cs 73.54% <0.00%> (+1.05%) ⬆️
src/Sentry/SentrySdk.cs 81.96% <0.00%> (+1.63%) ⬆️
src/Sentry.AspNetCore/SentryTracingMiddleware.cs 76.82% <0.00%> (+2.43%) ⬆️
src/Sentry/Extensibility/HubAdapter.cs 72.72% <0.00%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa6a149...62df16d. Read the comment docs.

@bruno-garcia bruno-garcia merged commit 0e2cad9 into main Oct 29, 2021
@bruno-garcia bruno-garcia deleted the feat/gcp-performance branch October 29, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request Google Cloud Functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants