Data from Scope in options should be applied on each request #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1270 +/- ##
==========================================
+ Coverage 81.83% 82.55% +0.71%
==========================================
Files 212 213 +1
Lines 7075 7089 +14
Branches 1396 1399 +3
==========================================
+ Hits 5790 5852 +62
+ Misses 845 801 -44
+ Partials 440 436 -4
Continue to review full report at Codecov.
|
SimonCropp
reviewed
Oct 28, 2021
|
minor changes re exception handling in tests. but the rest LGTM (considering my limited knowledge of the codebase) |
1 similar comment
|
minor changes re exception handling in tests. but the rest LGTM (considering my limited knowledge of the codebase) |
|
Since there are no more open comments about this PR I believe it's safe to say that it's read to Merge @bruno-garcia |
bruno-garcia
requested changes
Oct 30, 2021
bruno-garcia
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR applies the configure scopes stored on Sentry options into the hub once and reapplies it if the hud changed.
Close #968