Fix: GCP flush before error thrown. #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1249 +/- ##
==========================================
- Coverage 80.61% 79.33% -1.29%
==========================================
Files 212 212
Lines 6913 6920 +7
Branches 1591 1596 +5
==========================================
- Hits 5573 5490 -83
- Misses 809 911 +102
+ Partials 531 519 -12
Continue to review full report at Codecov.
|
SimonCropp
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new flush method called FlushBeforeRequestCompleted, instead of flushing after the request is sent like in FlushOnCompletedRequest, this flag sends the envelopes before sending the response to the user.
It's a required flow for some serverless/Faas platforms that will kill the process after flushing the HttpResponse to the receiver.
I made it internal for now and ideally in the future we could have a simple enum that will set the flush type (none, on completed, before completed).
Close #1213