Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add additional primitive values as tags on SentryLogger #1246

Merged

Conversation

lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented Oct 7, 2021

Users can now use other types of data for generating Tags, for example:
logger.LogError("Some Application error: {intTag}", 100500);
logger.LogError("Some Application error: {guidTag}", Guid.New());
logger.LogError("Some Application error: {doubleTag}", 12.34);

Close #260.

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2021

Codecov Report

Merging #1246 (ba40844) into main (ea877c7) will decrease coverage by 2.55%.
The diff coverage is 100.00%.

❗ Current head ba40844 differs from pull request most recent head 7bed9b5. Consider uploading reports for the commit 7bed9b5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1246      +/-   ##
==========================================
- Coverage   80.59%   78.03%   -2.56%     
==========================================
  Files         212      212              
  Lines        6904     6912       +8     
  Branches     1587     1591       +4     
==========================================
- Hits         5564     5394     -170     
- Misses        809      994     +185     
+ Partials      531      524       -7     
Impacted Files Coverage Δ
src/Sentry.Extensions.Logging/SentryLogger.cs 100.00% <100.00%> (ø)
src/Sentry/PlatformAbstractions/FrameworkInfo.cs 0.00% <0.00%> (-100.00%) ⬇️
...c/Sentry/Infrastructure/ConsoleDiagnosticLogger.cs 0.00% <0.00%> (-100.00%) ⬇️
...ntry/PlatformAbstractions/RegistryKeyExtensions.cs 0.00% <0.00%> (-100.00%) ⬇️
...entry/Extensibility/BaseRequestPayloadExtractor.cs 0.00% <0.00%> (-84.62%) ⬇️
...ry/Extensibility/DefaultRequestPayloadExtractor.cs 0.00% <0.00%> (-81.82%) ⬇️
...Sentry/PlatformAbstractions/FrameworkInfo.NetFx.cs 0.00% <0.00%> (-70.43%) ⬇️
...rmAbstractions/NetFxInstallationsEventProcessor.cs 4.54% <0.00%> (-68.19%) ⬇️
...entry/Extensibility/FormRequestPayloadExtractor.cs 0.00% <0.00%> (-66.67%) ⬇️
.../Sentry.AspNetCore.Grpc/SentryBuilderExtensions.cs 0.00% <0.00%> (-43.75%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea877c7...7bed9b5. Read the comment docs.

CHANGELOG.md Outdated Show resolved Hide resolved
@lucas-zimerman lucas-zimerman merged commit 6f14500 into main Oct 8, 2021
@lucas-zimerman lucas-zimerman deleted the feat/sentrylogger-add-additional-primitive-tags branch October 8, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LogEntry-level tags support strings only
3 participants