Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check crash callback for sessions #1222

Merged
merged 4 commits into from
Sep 29, 2021

Conversation

bruno-garcia
Copy link
Member

Instead of assuming a previous session was healthy if it was on the background. First check with the optional callback used for native integrations.

In order to debug this I had to adjust some of the debug logs. In the process I fix their format inconsistencies.

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2021

Codecov Report

Merging #1222 (388d2f3) into main (2cf2d02) will increase coverage by 0.13%.
The diff coverage is 58.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1222      +/-   ##
==========================================
+ Coverage   80.45%   80.59%   +0.13%     
==========================================
  Files         212      212              
  Lines        6924     6904      -20     
  Branches     1587     1587              
==========================================
- Hits         5571     5564       -7     
+ Misses        824      809      -15     
- Partials      529      531       +2     
Impacted Files Coverage Δ
src/Sentry/Internal/Hub.cs 69.84% <0.00%> (+3.50%) ⬆️
src/Sentry/GlobalSessionManager.cs 70.04% <68.00%> (+0.17%) ⬆️
...ry/Integrations/AppDomainProcessExitIntegration.cs 84.61% <75.00%> (-6.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cf2d02...388d2f3. Read the comment docs.

@bruno-garcia bruno-garcia merged commit 678944f into main Sep 29, 2021
@bruno-garcia bruno-garcia deleted the ref/session-crash-callback-first branch September 29, 2021 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants