Add missing PathBase. #1198
Merged
Add missing PathBase. #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…try/sentry-dotnet into fix/pathbase-not-captured
Codecov Report
@@ Coverage Diff @@
## main #1198 +/- ##
=======================================
Coverage 80.45% 80.45%
=======================================
Files 212 212
Lines 6908 6924 +16
Branches 1582 1587 +5
=======================================
+ Hits 5558 5571 +13
Misses 824 824
- Partials 526 529 +3
Continue to review full report at Codecov.
|
lucas-zimerman
changed the title
test/Sentry.AspNetCore.Tests/Extensions/HttpContextExtensionsTests.cs
Outdated
Show resolved
Hide resolved
josh-degraw
approved these changes
Sep 20, 2021
test/Sentry.AspNetCore.Tests/Extensions/HttpContextExtensionsTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Josh DeGraw <18509575+josh-degraw@users.noreply.github.com>
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
bruno-garcia
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor TryGetRouteTemplate and captured PathBase.
Close #1155.