Fix ParentSampledId being reset on Transaction
#1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1130 +/- ##
=======================================
Coverage 79.15% 79.15%
=======================================
Files 200 200
Lines 6614 6615 +1
Branches 1460 1460
=======================================
+ Hits 5235 5236 +1
Misses 913 913
Partials 466 466
Continue to review full report at Codecov.
|
bruno-garcia
approved these changes
Jul 17, 2021
| transaction.ParentSpanId.Should().Be(SpanId.Parse("1000000000000000")); | ||
| transaction.IsSampled.Should().BeFalse(); | ||
| sentryClient.Received(1).CaptureTransaction(Arg.Is<Transaction>(t => | ||
| t.Name == "GET /person/{id}" && |
There was a problem hiding this comment.
The issue was trasnaction?. and transaction was null so assert wasn't being called?
There was a problem hiding this comment.
No, it was fine. The problem is that the transaction was created correctly, it was not sent correctly. So I widened the test scope to cover that (by testing against ISentryClient).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1097