Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: missing Handled errors from ASP.NET Core. #1111

Merged
merged 7 commits into from
Jul 12, 2021

Conversation

lucas-zimerman
Copy link
Collaborator

Set the handled mechanism to false from errors captured on SentryMiddleware.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Alexey Golub <tyrrrrrr@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2021

Codecov Report

Merging #1111 (723c9bb) into main (525c0b5) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1111      +/-   ##
==========================================
+ Coverage   80.95%   80.98%   +0.03%     
==========================================
  Files         195      195              
  Lines        6420     6422       +2     
  Branches     1417     1417              
==========================================
+ Hits         5197     5201       +4     
+ Misses        762      761       -1     
+ Partials      461      460       -1     
Impacted Files Coverage Δ
src/Sentry.AspNetCore/SentryMiddleware.cs 98.57% <100.00%> (+2.98%) ⬆️
src/Sentry/Internal/BackgroundWorker.cs 84.24% <0.00%> (-0.69%) ⬇️
src/Sentry/GlobalSessionManager.cs 68.99% <0.00%> (+0.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 525c0b5...723c9bb. Read the comment docs.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! thank you

@bruno-garcia bruno-garcia enabled auto-merge (squash) July 12, 2021 16:59
@bruno-garcia bruno-garcia merged commit 1b7e3c8 into main Jul 12, 2021
@bruno-garcia bruno-garcia deleted the fix/missing-handled-on-sentrymiddleware branch July 12, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants