Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DebugDiagnosticLogger as the default logger for legacy ASP.NET #1012

Merged
merged 3 commits into from
May 24, 2021

Conversation

Tyrrrz
Copy link
Contributor

@Tyrrrz Tyrrrz commented May 24, 2021

Closes #971

@bruno-garcia bruno-garcia enabled auto-merge (squash) May 24, 2021 19:30
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2021

Codecov Report

Merging #1012 (97fcbfd) into main (796890b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1012      +/-   ##
==========================================
+ Coverage   81.24%   81.26%   +0.02%     
==========================================
  Files         184      184              
  Lines        5907     5908       +1     
  Branches     1456     1457       +1     
==========================================
+ Hits         4799     4801       +2     
+ Misses        691      690       -1     
  Partials      417      417              
Impacted Files Coverage Δ
src/Sentry.AspNet/SentryAspNetOptionsExtensions.cs 90.00% <100.00%> (+1.11%) ⬆️
src/Sentry/Infrastructure/DebugDiagnosticLogger.cs 50.00% <0.00%> (+50.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 796890b...97fcbfd. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Sentry.AspNet change the DiagnosticLogger to DebugDiagLogger
3 participants