Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http.HttpRequestOut OpenTelemetry spans not finished if filtered #3197

Closed
jamescrosswell opened this issue Mar 6, 2024 · 0 comments · Fixed by #3198
Closed

Http.HttpRequestOut OpenTelemetry spans not finished if filtered #3197

jamescrosswell opened this issue Mar 6, 2024 · 0 comments · Fixed by #3198
Assignees
Labels
Bug Something isn't working

Comments

@jamescrosswell
Copy link
Collaborator

jamescrosswell commented Mar 6, 2024

Problem

For background context see:

If OpenTelemetry is configured with filtering - e.g. as follows:

AddHttpClientInstrumentation(o => o.FilterHttpRequestMessage = _ => false)

... then our SentrySpanProcessor receives OnStart events for any outgoing requests from HttpClient but never receives a corresponding OnEnd event.

This leaves a bunch of SentrySpan instances accumulating in SpanProcessor._map, which never get cleaned up.

Investigation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant