Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undo renaming of ISpan #2867

Closed
jamescrosswell opened this issue Nov 19, 2023 · 1 comment · Fixed by #2870
Closed

Undo renaming of ISpan #2867

jamescrosswell opened this issue Nov 19, 2023 · 1 comment · Fixed by #2870
Assignees
@jamescrosswell
Milestone
4.0.0

Comments

@jamescrosswell
Copy link
Collaborator

jamescrosswell commented Nov 19, 2023 •
edited
Loading

As part of #2656 we renamed ISpan to ISpanTracer. However this change mainly benefits the SDK maintainers and impacts users's code too heavily (it makes upgrading to v4.0.0 painful).

We should undo this renaming before going live with v4.0.0.

It's possibly worth considering renaming the Span and Transaction classes to SpanData and TransactionData to disambiguate these from ISpan and ITransaction... but that might require further discussion and could be delayed until after the shift from Transactions to Spans more generally.
@jamescrosswell jamescrosswell added this to the 4.0.0 milestone Nov 19, 2023
@jamescrosswell jamescrosswell self-assigned this Nov 20, 2023
@jamescrosswell jamescrosswell changed the title Undo renaming of ISpan and ITransaction Undo renaming of ISpan Nov 20, 2023
@jamescrosswell jamescrosswell mentioned this issue Nov 20, 2023
Merged
@bitsandfoxes
Copy link
Contributor

Closed by #2870

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamescrosswell jamescrosswell

Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

Undo renaming of ISpan getsentry/sentry-dotnet
2 participants
@jamescrosswell @bitsandfoxes