Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SentryTracingMiddleware doesn't connect exception to trace-id #1042

Closed
bruno-garcia opened this issue Jun 4, 2021 · 1 comment · Fixed by #1043
Closed

SentryTracingMiddleware doesn't connect exception to trace-id #1042

bruno-garcia opened this issue Jun 4, 2021 · 1 comment · Fixed by #1043
Labels
Bug Something isn't working Product: Tracing

Comments

@bruno-garcia
Copy link
Member

When an exception is thrown through the tracing middleware SentryTracingMiddleware, the transaction is finished and the exception flows through.

This means the exception captured by the erro reporting SentryMiddleware is unaware that there was a transaction in that request and the two parts of the product are disconnected

SentryTracingMiddleware must have a catch block and set that exception reference to the weak reference map that connects exception instances to spans, so that upstream we can do the link between error and transaction.

@bruno-garcia bruno-garcia added Bug Something isn't working Product: Tracing labels Jun 4, 2021
@bruno-garcia
Copy link
Member Author

Resolved through #1043

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Product: Tracing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant