Skip to content

Commit

Permalink
Stop embedding PDBs (#2166)
Browse files Browse the repository at this point in the history
* Don't embed PDBs

* Publish symbols to nuget

* Update CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>

---------

Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
  • Loading branch information
mattjohnsonpint and bruno-garcia committed Feb 8, 2023
1 parent 0dbdab2 commit 6981108
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 6 deletions.
1 change: 1 addition & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,3 +72,4 @@ jobs:
if-no-files-found: error
path: |
${{ github.workspace }}/src/**/Release/*.nupkg
${{ github.workspace }}/src/**/Release/*.snupkg
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
### Fixes

- Workaround Visual Studio "Pair to Mac" issue (on Windows), and Update bundled Cocoa SDK to version 7.31.5 ([#2164](https://github.com/getsentry/sentry-dotnet/pull/2164))
- Sentry SDK assemblies no longer have PDBs embedded. Debug symbols are uploaded to `nuget.org` as `snupkg` packages ([#2166](https://github.com/getsentry/sentry-dotnet/pull/2166))

## 3.27.1

Expand Down
13 changes: 7 additions & 6 deletions src/Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,18 @@
<PackageLicenseExpression>MIT</PackageLicenseExpression>
<PackageReadmeFile>README.md</PackageReadmeFile>

<!-- Prop required by Microsoft.SourceLink.GitHub -->
<!-- Publish the repository URL in the built .nupkg (in the NuSpec <Repository> element) -->
<!--
SourceLink configuration
See https://github.com/dotnet/sourcelink/blob/main/README.md
And https://learn.microsoft.com/dotnet/core/project-sdk/msbuild-props
-->
<PublishRepositoryUrl>true</PublishRepositoryUrl>
<!-- Embed source files that are not tracked by the source control manager in the PDB -->
<IncludeSymbols>true</IncludeSymbols>
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
<EmbedUntrackedSources>true</EmbedUntrackedSources>
<!-- Embed PDB inside the assembly -->
<DebugType>embedded</DebugType>
<IncludeSourceRevisionInInformationalVersion>false</IncludeSourceRevisionInInformationalVersion>

<Nullable>annotations</Nullable>

<CodeAnalysisRuleSet>$(MSBuildThisFileDirectory)CodeAnalysis.ruleset</CodeAnalysisRuleSet>
</PropertyGroup>

Expand Down

0 comments on commit 6981108

Please sign in to comment.