-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aspcore guidance 2275 #7772
Aspcore guidance 2275 #7772
Conversation
@jamescrosswell is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
@bitsandfoxes another documentation change for your review. Possibly worth waiting for getsentry/sentry-dotnet#2602 though. It was relatively difficult to rewite the guidance in a way that was simple and easy to folow... mainly because setting up tracing in ASP.NET Core is complex and filled with nuance. Eventually I figured it was better to address the root cause of the problem than try to work around it 😜 |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small grammar/spelling tweaks, but otherwise looks good. Happy to review again if you end up making more changes.
Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
Pre-merge checklist
Description of changes
Addresses the documentation change components of getsentry/sentry-dotnet#2275. I'll create a separate pull request for in the sentry-dotnet repository for the code sample changes.