Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aspcore guidance 2275 #7772

Merged
merged 12 commits into from
Sep 27, 2023

Conversation

jamescrosswell
Copy link
Collaborator

Pre-merge checklist

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs
  • PR was reviewed and approved by a member of the Sentry docs team

Description of changes

Addresses the documentation change components of getsentry/sentry-dotnet#2275. I'll create a separate pull request for in the sentry-dotnet repository for the code sample changes.

@jamescrosswell jamescrosswell requested a review from a team as a code owner September 8, 2023 00:41
@vercel
Copy link

vercel bot commented Sep 8, 2023

@jamescrosswell is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@jamescrosswell
Copy link
Collaborator Author

jamescrosswell commented Sep 8, 2023

@bitsandfoxes another documentation change for your review.

Possibly worth waiting for getsentry/sentry-dotnet#2602 though. It was relatively difficult to rewite the guidance in a way that was simple and easy to folow... mainly because setting up tracing in ASP.NET Core is complex and filled with nuance. Eventually I figured it was better to address the root cause of the problem than try to work around it 😜

@vercel
Copy link

vercel bot commented Sep 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2023 0:12am

Copy link
Contributor

@shanamatthews shanamatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small grammar/spelling tweaks, but otherwise looks good. Happy to review again if you end up making more changes.

src/platforms/dotnet/guides/aspnetcore/index.mdx Outdated Show resolved Hide resolved
src/platforms/dotnet/guides/aspnetcore/index.mdx Outdated Show resolved Hide resolved
src/platforms/dotnet/guides/aspnetcore/index.mdx Outdated Show resolved Hide resolved
src/platforms/dotnet/guides/aspnetcore/index.mdx Outdated Show resolved Hide resolved
src/platforms/dotnet/guides/aspnetcore/index.mdx Outdated Show resolved Hide resolved
jamescrosswell and others added 5 commits September 26, 2023 12:06
Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
src/platforms/dotnet/guides/aspnetcore/index.mdx Outdated Show resolved Hide resolved
src/platforms/dotnet/guides/aspnetcore/index.mdx Outdated Show resolved Hide resolved
@bitsandfoxes bitsandfoxes enabled auto-merge (squash) September 27, 2023 10:13
@bitsandfoxes bitsandfoxes merged commit 77dfb4c into getsentry:master Sep 27, 2023
5 of 6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants