Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document SetBeforeSend, SetBeforeSendTransaction, and SetBeforeBreadcrumb in .NET #7455

Closed
rodolfoBee opened this issue Jul 18, 2023 · 3 comments
Closed

Document SetBeforeSend, SetBeforeSendTransaction, and SetBeforeBreadcrumb in .NET #7455

rodolfoBee opened this issue Jul 18, 2023 · 3 comments
Labels
Product Area: SDKs - Web Backend Waiting for: Product Owner

Comments

@rodolfoBee
Copy link
Member

Core or SDK?

Platform/SDK

Which part? Which one?

.NET Filtering

Description

v3.32.0 of the SDK introduced the following change with zero documentation:

Add Hint support (getsentry/sentry-dotnet#2351)

  • Currently, this allows you to manipulate attachments in the various "before" event delegates.
  • Hints can also be used in event and transaction processors by implementing ISentryEventProcessorWithHint or ISentryTransactionProcessorWithHint, instead of ISentryEventProcessor or ISentryTransactionProcessor.
  • Note: Obsoletes the BeforeSend, BeforeSendTransaction, and BeforeBreadcrumb properties on the SentryOptions class. They have been replaced with SetBeforeSend, SetBeforeSendTransaction, and SetBeforeBreadcrumb respectively. Each one provides overloads both with and without a Hint object.

Suggested Solution

Document the correct usage of hint and the three updated "before" callbacks.
@getsantry
Copy link
Contributor

getsantry bot commented Jul 18, 2023

Assigning to @getsentry/support for routing ⏲️

@getsantry getsantry bot moved this to Waiting for: Support in GitHub Issues with 👀 Jul 18, 2023
@getsantry
Copy link
Contributor

getsantry bot commented Jul 18, 2023

Routing to @getsentry/product-owners-sdks-web-backend for triage ⏲️

@getsantry getsantry bot moved this from Waiting for: Support to Waiting for: Product Owner in GitHub Issues with 👀 Jul 18, 2023
@bitsandfoxes
Copy link
Contributor

Resolved by #7477

@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Product Area: SDKs - Web Backend Waiting for: Product Owner
Projects
GitHub Issues with 👀
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bitsandfoxes @rodolfoBee