Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package Analysis step in CI does not upload results for contributors #840

Closed
ueman opened this issue Apr 21, 2022 · 3 comments
Closed

Package Analysis step in CI does not upload results for contributors #840

ueman opened this issue Apr 21, 2022 · 3 comments

Comments

@ueman
Copy link
Collaborator

ueman commented Apr 21, 2022

From https://github.com/getsentry/sentry-dart/runs/6113791214?check_suite_focus=true

Warning: It seems that this action doesn't have the required permissions to call the GitHub API with the token you gave. This can occur if this repository is a fork, as in that case GitHub reduces the GITHUB_TOKEN's permissions for security reasons. Consequently, no report will be made on GitHub. Check this issue for more information: axel-op/dart-package-analyzer#2

@marandaneto
Copy link
Contributor

@ueman that's fine, it does not fail because of that tho, it fails because of dart-lang/pana#1020
It's still useful to run pana from forks, or do you mean something else?

@ueman
Copy link
Collaborator Author

ueman commented Apr 22, 2022

The issue is, that a contributer doesn't really know what's wrong if it fails because the result isn't uploaded.

@vaind
Copy link
Collaborator

vaind commented Nov 7, 2022

I'm voting to close this - the CI job prints failure to logs - all the info is there for contributors to see and fix. Yes, it's not easy to read, but it's actionable. This could maybe be improved in the dependent action if it is really troublesome to many people but I wouldn't track it in this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants