From 7b4ce83eaf14666d82092cd65b2e900765fb1d8f Mon Sep 17 00:00:00 2001 From: Giancarlo Buenaflor Date: Fri, 13 Dec 2024 16:53:31 +0100 Subject: [PATCH 1/4] fix: SentryWidgetsFlutterBinding initializing even if a binding already exists (#2494) * add additional test case * larger runner * match ci like in main branch --- .github/workflows/flutter.yml | 4 +- .github/workflows/flutter_test.yml | 56 +++++++++---------- CHANGELOG.md | 7 +++ .../sentry_widgets_flutter_binding_test.dart | 28 ++++++++++ .../integration_test/test_driver/driver.dart | 3 + flutter/lib/src/binding_wrapper.dart | 25 +++------ ...=> sentry_widgets_binding_mixin_test.dart} | 0 .../sentry_widgets_flutter_binding_test.dart | 20 +++++++ 8 files changed, 95 insertions(+), 48 deletions(-) create mode 100644 flutter/example/integration_test/sentry_widgets_flutter_binding_test.dart create mode 100644 flutter/example/integration_test/test_driver/driver.dart rename flutter/test/{sentry_flutter_widgets_binding_test.dart => sentry_widgets_binding_mixin_test.dart} (100%) create mode 100644 flutter/test/sentry_widgets_flutter_binding_test.dart diff --git a/.github/workflows/flutter.yml b/.github/workflows/flutter.yml index 5a5e469bea..136c29c149 100644 --- a/.github/workflows/flutter.yml +++ b/.github/workflows/flutter.yml @@ -84,13 +84,13 @@ jobs: if: matrix.target == 'web' run: | flutter test --platform chrome --test-randomize-ordering-seed=random --exclude-tags canvasKit - flutter test --platform chrome --test-randomize-ordering-seed=random --tags canvasKit --web-renderer canvaskit + flutter test --platform chrome --test-randomize-ordering-seed=random --tags canvasKit - name: Test web (WASM) if: matrix.target == 'web' run: | flutter test --platform chrome --wasm --test-randomize-ordering-seed=random --exclude-tags canvasKit - flutter test --platform chrome --wasm --test-randomize-ordering-seed=random --tags canvasKit --web-renderer canvaskit + flutter test --platform chrome --wasm --test-randomize-ordering-seed=random --tags canvasKit - name: Test VM with coverage if: matrix.target == 'linux' || matrix.target == 'macos' || matrix.target == 'windows' diff --git a/.github/workflows/flutter_test.yml b/.github/workflows/flutter_test.yml index 1bfd543a4d..538e0dfab2 100644 --- a/.github/workflows/flutter_test.yml +++ b/.github/workflows/flutter_test.yml @@ -25,7 +25,7 @@ jobs: access_token: ${{ github.token }} test-android: - runs-on: macos-13 + runs-on: ubuntu-latest timeout-minutes: 30 defaults: run: @@ -38,6 +38,12 @@ jobs: - name: checkout uses: actions/checkout@v4 + - name: Enable KVM group perms + run: | + echo 'KERNEL=="kvm", GROUP="kvm", MODE="0666", OPTIONS+="static_node=kvm"' | sudo tee /etc/udev/rules.d/99-kvm4all.rules + sudo udevadm control --reload-rules + sudo udevadm trigger --name-match=kvm + - uses: actions/setup-java@v4 with: distribution: "adopt" @@ -56,28 +62,7 @@ jobs: - name: Gradle cache uses: gradle/gradle-build-action@ac2d340dc04d9e1113182899e983b5400c17cda1 # pin@v3.0.0 - - name: AVD cache - uses: actions/cache@v4 - id: avd-cache - with: - path: | - ~/.android/avd/* - ~/.android/adb* - key: avd-31 - - - name: create AVD and generate snapshot for caching - if: steps.avd-cache.outputs.cache-hit != 'true' - uses: reactivecircus/android-emulator-runner@62dbb605bba737720e10b196cb4220d374026a6d #pin@v2.33.0 - with: - working-directory: ./flutter/example - api-level: 31 - profile: Nexus 6 - arch: x86_64 - force-avd-creation: false - avd-name: macOS-avd-x86_64-31 - emulator-options: -no-snapshot-save -no-window -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none - disable-animations: true - script: echo 'Generated AVD snapshot for caching.' + # TODO: fix emulator caching, in ubuntu-latest emulator won't boot: https://github.com/ReactiveCircus/android-emulator-runner/issues/278 - name: build apk working-directory: ./flutter/example/android @@ -91,8 +76,8 @@ jobs: profile: Nexus 6 arch: x86_64 force-avd-creation: false - avd-name: macOS-avd-x86_64-31 - emulator-options: -no-snapshot-save -no-window -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none + avd-name: avd-x86_64-31 + emulator-options: -no-snapshot-save -no-window -accel on -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none disable-animations: true script: ./gradlew testDebugUnitTest @@ -104,11 +89,24 @@ jobs: profile: Nexus 6 arch: x86_64 force-avd-creation: false - avd-name: macOS-avd-x86_64-31 - emulator-options: -no-snapshot-save -no-window -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none + avd-name: avd-x86_64-31 + emulator-options: -no-snapshot-save -no-window -accel on -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none disable-animations: true script: flutter test integration_test/all.dart --verbose + - name: launch android emulator & run android integration test in profile mode + uses: reactivecircus/android-emulator-runner@62dbb605bba737720e10b196cb4220d374026a6d #pin@v2.33.0 + with: + working-directory: ./flutter/example + api-level: 31 + profile: Nexus 6 + arch: x86_64 + force-avd-creation: false + avd-name: avd-x86_64-31 + emulator-options: -no-snapshot-save -no-window -accel on -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none + disable-animations: true + script: flutter drive --driver=integration_test/test_driver/driver.dart --target=integration_test/sentry_widgets_flutter_binding_test.dart --profile -d emulator-5554 + cocoa: name: "${{ matrix.target }} | ${{ matrix.sdk }}" runs-on: macos-latest-xlarge @@ -158,7 +156,9 @@ jobs: - name: run integration test # Disable flutter integration tests for iOS for now (https://github.com/getsentry/sentry-dart/issues/1605#issuecomment-1695809346) if: ${{ matrix.target != 'ios' }} - run: flutter test -d "${{ steps.device.outputs.name }}" integration_test/all.dart --verbose + run: | + flutter test -d "${{ steps.device.outputs.name }}" integration_test/all.dart --verbose + flutter drive --driver=integration_test/test_driver/driver.dart --target=integration_test/sentry_widgets_flutter_binding_test.dart --profile -d "${{ steps.device.outputs.name }}" - name: run native test # We only have the native unit test package in the iOS xcodeproj at the moment. diff --git a/CHANGELOG.md b/CHANGELOG.md index 66c3006ede..e74d44cf00 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,12 @@ # Changelog +## Unreleased + + +### Fixes + +- SentryWidgetsFlutterBinding initializing even if a binding already exists ([#2494](https://github.com/getsentry/sentry-dart/pull/2494)) + ## 8.11.0 ### Features diff --git a/flutter/example/integration_test/sentry_widgets_flutter_binding_test.dart b/flutter/example/integration_test/sentry_widgets_flutter_binding_test.dart new file mode 100644 index 0000000000..b13b32d36c --- /dev/null +++ b/flutter/example/integration_test/sentry_widgets_flutter_binding_test.dart @@ -0,0 +1,28 @@ +// ignore_for_file: avoid_print +// ignore_for_file: invalid_use_of_internal_member + +import 'package:flutter_test/flutter_test.dart'; +import 'package:integration_test/integration_test.dart'; +import 'package:sentry_flutter/sentry_flutter.dart'; + +// This needs needs to be run with: +// +// flutter drive \ +// --driver=integration_test/test_driver/driver.dart \ +// --target=integration_test/sentry_widgets_flutter_binding_test.dart --profile +// +// This test case will NOT fail in debug builds, hence why we need to test it +// in at least a profile build. + +void main() { + final originalBinding = + IntegrationTestWidgetsFlutterBinding.ensureInitialized(); + + group('$SentryWidgetsFlutterBinding', () { + testWidgets('return existing binding', (tester) async { + final binding = SentryWidgetsFlutterBinding.ensureInitialized(); + + expect(binding, equals(originalBinding)); + }); + }); +} diff --git a/flutter/example/integration_test/test_driver/driver.dart b/flutter/example/integration_test/test_driver/driver.dart new file mode 100644 index 0000000000..b38629cca9 --- /dev/null +++ b/flutter/example/integration_test/test_driver/driver.dart @@ -0,0 +1,3 @@ +import 'package:integration_test/integration_test_driver.dart'; + +Future main() => integrationDriver(); diff --git a/flutter/lib/src/binding_wrapper.dart b/flutter/lib/src/binding_wrapper.dart index 823df58bf4..8df735bbda 100644 --- a/flutter/lib/src/binding_wrapper.dart +++ b/flutter/lib/src/binding_wrapper.dart @@ -1,6 +1,5 @@ // ignore_for_file: invalid_use_of_internal_member -import 'package:flutter/foundation.dart'; import 'package:flutter/widgets.dart'; import 'package:meta/meta.dart'; @@ -48,16 +47,6 @@ WidgetsBinding? _ambiguate(WidgetsBinding? binding) => binding; class SentryWidgetsFlutterBinding extends WidgetsFlutterBinding with SentryWidgetsBindingMixin { - @override - void initInstances() { - super.initInstances(); - _instance = this; - } - - static SentryWidgetsFlutterBinding get instance => - BindingBase.checkInstance(_instance); - static SentryWidgetsFlutterBinding? _instance; - /// Returns an instance of [SentryWidgetsFlutterBinding]. /// If no binding has yet been initialized, creates and initializes one. /// @@ -65,15 +54,15 @@ class SentryWidgetsFlutterBinding extends WidgetsFlutterBinding /// returns the existing [WidgetsBinding] instance instead. static WidgetsBinding ensureInitialized() { try { - if (SentryWidgetsFlutterBinding._instance == null) { - SentryWidgetsFlutterBinding(); - } - return SentryWidgetsFlutterBinding.instance; - } catch (e) { + // Try to get the existing binding instance + return WidgetsBinding.instance; + } catch (_) { Sentry.currentHub.options.logger( SentryLevel.info, - 'WidgetsFlutterBinding already initialized. ' - 'Falling back to default WidgetsBinding instance.'); + 'WidgetsFlutterBinding has not been initialized yet. ' + 'Creating $SentryWidgetsFlutterBinding.'); + // No binding exists yet, create our custom one + SentryWidgetsFlutterBinding(); return WidgetsBinding.instance; } } diff --git a/flutter/test/sentry_flutter_widgets_binding_test.dart b/flutter/test/sentry_widgets_binding_mixin_test.dart similarity index 100% rename from flutter/test/sentry_flutter_widgets_binding_test.dart rename to flutter/test/sentry_widgets_binding_mixin_test.dart diff --git a/flutter/test/sentry_widgets_flutter_binding_test.dart b/flutter/test/sentry_widgets_flutter_binding_test.dart new file mode 100644 index 0000000000..6e51f73eb4 --- /dev/null +++ b/flutter/test/sentry_widgets_flutter_binding_test.dart @@ -0,0 +1,20 @@ +import 'package:flutter/widgets.dart'; +import 'package:flutter_test/flutter_test.dart'; +import 'package:sentry_flutter/src/binding_wrapper.dart'; + +// Note: testing that SentryWidgetsFlutterBinding.ensureInitialized() returns +// the existing binding if one exists is not reliable to test in debug builds +// A previous faulty implementation was passing in debug but not in profile/release builds +// See flutter/example/integration_test/sentry_widgets_flutter_binding_test.dart + +void main() { + group('$SentryWidgetsFlutterBinding', () { + test( + 'no existing binding: ensureInitialized() returns SentryWidgetsFlutterBinding binding', + () { + final binding = SentryWidgetsFlutterBinding.ensureInitialized(); + + expect(binding, equals(WidgetsBinding.instance)); + }); + }); +} From a8bff7d9df812361a99cf0567fdca190b6166f70 Mon Sep 17 00:00:00 2001 From: Giancarlo Buenaflor Date: Fri, 13 Dec 2024 18:06:41 +0100 Subject: [PATCH 2/4] improvement: check for `SentryTracer` type in TTID (#2497) * fix * update * update CHANGELOG --- CHANGELOG.md | 3 +++ .../lib/src/navigation/time_to_initial_display_tracker.dart | 6 ++++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e74d44cf00..9bc18f5313 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,9 @@ ## Unreleased +### Improvements + +- Check for type before casting in TTID ([#2497](https://github.com/getsentry/sentry-dart/pull/2497)) ### Fixes diff --git a/flutter/lib/src/navigation/time_to_initial_display_tracker.dart b/flutter/lib/src/navigation/time_to_initial_display_tracker.dart index 5213d4587c..3509dc6c4d 100644 --- a/flutter/lib/src/navigation/time_to_initial_display_tracker.dart +++ b/flutter/lib/src/navigation/time_to_initial_display_tracker.dart @@ -51,11 +51,13 @@ class TimeToInitialDisplayTracker { final _endTimestamp = endTimestamp ?? await determineEndTime(); if (_endTimestamp == null) return; - final tracer = transaction as SentryTracer; + if (transaction is! SentryTracer) { + return; + } final ttidSpan = transaction.startChild( SentrySpanOperations.uiTimeToInitialDisplay, - description: '${tracer.name} initial display', + description: '${transaction.name} initial display', startTimestamp: startTimestamp, ); From c3aeb1f8992e8feda5c1b0569f5d992b2a51d347 Mon Sep 17 00:00:00 2001 From: getsentry-bot Date: Mon, 16 Dec 2024 09:19:40 +0000 Subject: [PATCH 3/4] release: 8.11.1 --- CHANGELOG.md | 2 +- dart/lib/src/version.dart | 2 +- dart/pubspec.yaml | 2 +- dio/lib/src/version.dart | 2 +- dio/pubspec.yaml | 4 ++-- drift/lib/src/version.dart | 2 +- drift/pubspec.yaml | 4 ++-- file/lib/src/version.dart | 2 +- file/pubspec.yaml | 4 ++-- flutter/example/pubspec.yaml | 2 +- flutter/lib/src/version.dart | 2 +- flutter/pubspec.yaml | 4 ++-- hive/lib/src/version.dart | 2 +- hive/pubspec.yaml | 4 ++-- isar/lib/src/version.dart | 2 +- isar/pubspec.yaml | 4 ++-- logging/lib/src/version.dart | 2 +- logging/pubspec.yaml | 4 ++-- sqflite/lib/src/version.dart | 2 +- sqflite/pubspec.yaml | 4 ++-- 20 files changed, 28 insertions(+), 28 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9bc18f5313..9a6d64a8bb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,6 @@ # Changelog -## Unreleased +## 8.11.1 ### Improvements diff --git a/dart/lib/src/version.dart b/dart/lib/src/version.dart index d1f0aa94e7..1efd249a21 100644 --- a/dart/lib/src/version.dart +++ b/dart/lib/src/version.dart @@ -9,7 +9,7 @@ library version; /// The SDK version reported to Sentry.io in the submitted events. -const String sdkVersion = '8.11.0'; +const String sdkVersion = '8.11.1'; String sdkName(bool isWeb) => isWeb ? _browserSdkName : _ioSdkName; diff --git a/dart/pubspec.yaml b/dart/pubspec.yaml index a671319420..ecfcf25a01 100644 --- a/dart/pubspec.yaml +++ b/dart/pubspec.yaml @@ -1,5 +1,5 @@ name: sentry -version: 8.11.0 +version: 8.11.1 description: > A crash reporting library for Dart that sends crash reports to Sentry.io. This library supports Dart VM and Web. For Flutter consider sentry_flutter instead. diff --git a/dio/lib/src/version.dart b/dio/lib/src/version.dart index 6c0256435a..357f01db20 100644 --- a/dio/lib/src/version.dart +++ b/dio/lib/src/version.dart @@ -1,5 +1,5 @@ /// The SDK version reported to Sentry.io in the submitted events. -const String sdkVersion = '8.11.0'; +const String sdkVersion = '8.11.1'; /// The package name reported to Sentry.io in the submitted events. const String packageName = 'pub:sentry_dio'; diff --git a/dio/pubspec.yaml b/dio/pubspec.yaml index d390a9e1a1..507865a740 100644 --- a/dio/pubspec.yaml +++ b/dio/pubspec.yaml @@ -1,6 +1,6 @@ name: sentry_dio description: An integration which adds support for performance tracing for the Dio package. -version: 8.11.0 +version: 8.11.1 homepage: https://docs.sentry.io/platforms/dart/ repository: https://github.com/getsentry/sentry-dart issue_tracker: https://github.com/getsentry/sentry-dart/issues @@ -19,7 +19,7 @@ platforms: dependencies: dio: ^5.0.0 - sentry: 8.11.0 + sentry: 8.11.1 dev_dependencies: meta: ^1.3.0 diff --git a/drift/lib/src/version.dart b/drift/lib/src/version.dart index 656652fa8d..556e41991c 100644 --- a/drift/lib/src/version.dart +++ b/drift/lib/src/version.dart @@ -1,5 +1,5 @@ /// The SDK version reported to Sentry.io in the submitted events. -const String sdkVersion = '8.11.0'; +const String sdkVersion = '8.11.1'; /// The package name reported to Sentry.io in the submitted events. const String packageName = 'pub:sentry_drift'; diff --git a/drift/pubspec.yaml b/drift/pubspec.yaml index 141bf7b05c..2c7de04966 100644 --- a/drift/pubspec.yaml +++ b/drift/pubspec.yaml @@ -1,6 +1,6 @@ name: sentry_drift description: An integration which adds support for performance tracing for the drift package. -version: 8.11.0 +version: 8.11.1 homepage: https://docs.sentry.io/platforms/flutter/ repository: https://github.com/getsentry/sentry-dart issue_tracker: https://github.com/getsentry/sentry-dart/issues @@ -17,7 +17,7 @@ platforms: web: dependencies: - sentry: 8.11.0 + sentry: 8.11.1 meta: ^1.3.0 drift: ^2.13.0 diff --git a/file/lib/src/version.dart b/file/lib/src/version.dart index 162da555ab..583d8de50c 100644 --- a/file/lib/src/version.dart +++ b/file/lib/src/version.dart @@ -1,5 +1,5 @@ /// The SDK version reported to Sentry.io in the submitted events. -const String sdkVersion = '8.11.0'; +const String sdkVersion = '8.11.1'; /// The package name reported to Sentry.io in the submitted events. const String packageName = 'pub:sentry_file'; diff --git a/file/pubspec.yaml b/file/pubspec.yaml index 5429bbb060..e4b5354089 100644 --- a/file/pubspec.yaml +++ b/file/pubspec.yaml @@ -1,6 +1,6 @@ name: sentry_file description: An integration which adds support for performance tracing for dart.io.File. -version: 8.11.0 +version: 8.11.1 homepage: https://docs.sentry.io/platforms/dart/ repository: https://github.com/getsentry/sentry-dart issue_tracker: https://github.com/getsentry/sentry-dart/issues @@ -17,7 +17,7 @@ platforms: windows: dependencies: - sentry: 8.11.0 + sentry: 8.11.1 meta: ^1.3.0 dev_dependencies: diff --git a/flutter/example/pubspec.yaml b/flutter/example/pubspec.yaml index 1bf1e2d744..361087bd05 100644 --- a/flutter/example/pubspec.yaml +++ b/flutter/example/pubspec.yaml @@ -1,6 +1,6 @@ name: sentry_flutter_example description: Demonstrates how to use the sentry_flutter plugin. -version: 8.11.0 +version: 8.11.1 publish_to: 'none' # Remove this line if you wish to publish to pub.dev diff --git a/flutter/lib/src/version.dart b/flutter/lib/src/version.dart index be9882fd5a..19e42dd1a5 100644 --- a/flutter/lib/src/version.dart +++ b/flutter/lib/src/version.dart @@ -1,5 +1,5 @@ /// The SDK version reported to Sentry.io in the submitted events. -const String sdkVersion = '8.11.0'; +const String sdkVersion = '8.11.1'; /// The default SDK name reported to Sentry.io in the submitted events. const String sdkName = 'sentry.dart.flutter'; diff --git a/flutter/pubspec.yaml b/flutter/pubspec.yaml index 9bdb3c186d..098a268399 100644 --- a/flutter/pubspec.yaml +++ b/flutter/pubspec.yaml @@ -1,5 +1,5 @@ name: sentry_flutter -version: 8.11.0 +version: 8.11.1 description: Sentry SDK for Flutter. This package aims to support different Flutter targets by relying on the many platforms supported by Sentry with native SDKs. homepage: https://docs.sentry.io/platforms/flutter/ repository: https://github.com/getsentry/sentry-dart @@ -23,7 +23,7 @@ dependencies: sdk: flutter flutter_web_plugins: sdk: flutter - sentry: 8.11.0 + sentry: 8.11.1 package_info_plus: '>=1.0.0' meta: ^1.3.0 ffi: ^2.0.0 diff --git a/hive/lib/src/version.dart b/hive/lib/src/version.dart index feec20e9d4..85118ebc94 100644 --- a/hive/lib/src/version.dart +++ b/hive/lib/src/version.dart @@ -1,5 +1,5 @@ /// The SDK version reported to Sentry.io in the submitted events. -const String sdkVersion = '8.11.0'; +const String sdkVersion = '8.11.1'; /// The package name reported to Sentry.io in the submitted events. const String packageName = 'pub:sentry_hive'; diff --git a/hive/pubspec.yaml b/hive/pubspec.yaml index bbdce4a732..0051e4b2d4 100644 --- a/hive/pubspec.yaml +++ b/hive/pubspec.yaml @@ -1,6 +1,6 @@ name: sentry_hive description: An integration which adds support for performance tracing for the hive package. -version: 8.11.0 +version: 8.11.1 homepage: https://docs.sentry.io/platforms/flutter/ repository: https://github.com/getsentry/sentry-dart issue_tracker: https://github.com/getsentry/sentry-dart/issues @@ -17,7 +17,7 @@ platforms: web: dependencies: - sentry: 8.11.0 + sentry: 8.11.1 hive: ^2.2.3 meta: ^1.3.0 diff --git a/isar/lib/src/version.dart b/isar/lib/src/version.dart index e6f2293be6..4b77e4a8a2 100644 --- a/isar/lib/src/version.dart +++ b/isar/lib/src/version.dart @@ -1,5 +1,5 @@ /// The SDK version reported to Sentry.io in the submitted events. -const String sdkVersion = '8.11.0'; +const String sdkVersion = '8.11.1'; /// The package name reported to Sentry.io in the submitted events. const String packageName = 'pub:sentry_isar'; diff --git a/isar/pubspec.yaml b/isar/pubspec.yaml index 587b8f3e30..3ada427d41 100644 --- a/isar/pubspec.yaml +++ b/isar/pubspec.yaml @@ -1,6 +1,6 @@ name: sentry_isar description: An integration which adds support for performance tracing for the isar package. -version: 8.11.0 +version: 8.11.1 homepage: https://docs.sentry.io/platforms/flutter/ repository: https://github.com/getsentry/sentry-dart issue_tracker: https://github.com/getsentry/sentry-dart/issues @@ -20,7 +20,7 @@ platforms: dependencies: isar: ^3.1.0 isar_flutter_libs: ^3.1.0 # contains Isar Core - sentry: 8.11.0 + sentry: 8.11.1 meta: ^1.3.0 path: ^1.8.3 diff --git a/logging/lib/src/version.dart b/logging/lib/src/version.dart index 8586afc145..c48f7c8c71 100644 --- a/logging/lib/src/version.dart +++ b/logging/lib/src/version.dart @@ -1,5 +1,5 @@ /// The SDK version reported to Sentry.io in the submitted events. -const String sdkVersion = '8.11.0'; +const String sdkVersion = '8.11.1'; /// The package name reported to Sentry.io in the submitted events. const String packageName = 'pub:sentry_logging'; diff --git a/logging/pubspec.yaml b/logging/pubspec.yaml index f5760d2ede..9d8ff29115 100644 --- a/logging/pubspec.yaml +++ b/logging/pubspec.yaml @@ -1,6 +1,6 @@ name: sentry_logging description: An integration which adds support for recording log from the logging package. -version: 8.11.0 +version: 8.11.1 homepage: https://docs.sentry.io/platforms/dart/ repository: https://github.com/getsentry/sentry-dart issue_tracker: https://github.com/getsentry/sentry-dart/issues @@ -19,7 +19,7 @@ platforms: dependencies: logging: ^1.0.0 - sentry: 8.11.0 + sentry: 8.11.1 dev_dependencies: lints: '>=2.0.0' diff --git a/sqflite/lib/src/version.dart b/sqflite/lib/src/version.dart index cc7043409d..991c2381a7 100644 --- a/sqflite/lib/src/version.dart +++ b/sqflite/lib/src/version.dart @@ -1,5 +1,5 @@ /// The SDK version reported to Sentry.io in the submitted events. -const String sdkVersion = '8.11.0'; +const String sdkVersion = '8.11.1'; /// The package name reported to Sentry.io in the submitted events. const String packageName = 'pub:sentry_sqflite'; diff --git a/sqflite/pubspec.yaml b/sqflite/pubspec.yaml index 20fd6c5791..8c143ac62f 100644 --- a/sqflite/pubspec.yaml +++ b/sqflite/pubspec.yaml @@ -1,6 +1,6 @@ name: sentry_sqflite description: An integration which adds support for performance tracing for the sqflite package. -version: 8.11.0 +version: 8.11.1 homepage: https://docs.sentry.io/platforms/flutter/ repository: https://github.com/getsentry/sentry-dart issue_tracker: https://github.com/getsentry/sentry-dart/issues @@ -15,7 +15,7 @@ platforms: macos: dependencies: - sentry: 8.11.0 + sentry: 8.11.1 sqflite: ^2.2.8 sqflite_common: ^2.0.0 meta: ^1.3.0 From da1731970e02d3de7f485f6f98f882ab425a927f Mon Sep 17 00:00:00 2001 From: GIancarlo Buenaflor Date: Mon, 16 Dec 2024 11:04:42 +0100 Subject: [PATCH 4/4] update CHANGELOGmd --- CHANGELOG.md | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2b37fb8f24..3237d98d57 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,14 +1,5 @@ # Changelog -## 8.11.1 - -### Improvements - -- Check for type before casting in TTID ([#2497](https://github.com/getsentry/sentry-dart/pull/2497)) - -### Fixes - -- SentryWidgetsFlutterBinding initializing even if a binding already exists ([#2494](https://github.com/getsentry/sentry-dart/pull/2494)) ## Unreleased ### Deprecate @@ -28,6 +19,16 @@ - [changelog](https://github.com/getsentry/sentry-java/blob/main/CHANGELOG.md#7190) - [diff](https://github.com/getsentry/sentry-java/compare/7.18.1...7.19.0) +## 8.11.1 + +### Improvements + +- Check for type before casting in TTID ([#2497](https://github.com/getsentry/sentry-dart/pull/2497)) + +### Fixes + +- SentryWidgetsFlutterBinding initializing even if a binding already exists ([#2494](https://github.com/getsentry/sentry-dart/pull/2494)) + ## 8.12.0-beta.1 ### Features