From 0d8652b1f274eca32c7e205491796afbabb0942e Mon Sep 17 00:00:00 2001 From: Ivan Dlugos Date: Mon, 30 Oct 2023 12:13:58 +0100 Subject: [PATCH] minor fixes --- .../bin/flutter_symbol_collector.dart | 6 +++--- .../lib/src/symbol_collector_cli.dart | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/flutter_symbol_collector/bin/flutter_symbol_collector.dart b/scripts/flutter_symbol_collector/bin/flutter_symbol_collector.dart index a2957e15fb..424134eea7 100644 --- a/scripts/flutter_symbol_collector/bin/flutter_symbol_collector.dart +++ b/scripts/flutter_symbol_collector/bin/flutter_symbol_collector.dart @@ -33,7 +33,7 @@ void main(List arguments) async { !argVersion.contains('*') && argVersion.split('.').length == 3) { Logger.root.info('Running for a single flutter version: $argVersion'); - await processFlutterVerion(FlutterVersion(argVersion)); + await processFlutterVersion(FlutterVersion(argVersion)); } else { // Otherwise, walk all the versions and run for the matching ones. final versionRegex = RegExp(argVersion.isEmpty @@ -48,12 +48,12 @@ void main(List arguments) async { Logger.root.info( 'Found ${versions.length} Flutter versions matching $versionRegex'); for (var version in versions) { - await processFlutterVerion(version); + await processFlutterVersion(version); } } } -Future processFlutterVerion(FlutterVersion version) async { +Future processFlutterVersion(FlutterVersion version) async { if (bool.hasEnvironment('CI')) { print('::group::Processing Flutter ${version.tagName}'); } diff --git a/scripts/flutter_symbol_collector/lib/src/symbol_collector_cli.dart b/scripts/flutter_symbol_collector/lib/src/symbol_collector_cli.dart index d825c0c89f..0f4c97d6a6 100644 --- a/scripts/flutter_symbol_collector/lib/src/symbol_collector_cli.dart +++ b/scripts/flutter_symbol_collector/lib/src/symbol_collector_cli.dart @@ -70,13 +70,13 @@ class SymbolCollectorCli { void _ensureIsExecutable() { if (!_isExecutable) { - _isExecutable = true; if (LocalPlatform().operatingSystem == platform.operatingSystem) { if (platform.isLinux || platform.isMacOS) { _log.fine('Making Symbol-collector CLI executable (chmod +x)'); posix.chmod(cli, '0700'); } + _isExecutable = true; } else { _log.warning( 'Symbol-collector CLI has been run with a platform that is not the current OS platform.'