You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Previously I've removed potential crashers in test code in #4125 and #4132, but I guess I didn't think to look for this. Just noticed it, and we currently have 69 instances. Most should be an easy conversion of the enclosing test cases to throws, but a few are property intializers on Fixture instances that will need a little more work to maybe change to optional types.
The text was updated successfully, but these errors were encountered:
If we can't make it in a big bang, we should tackle this opportunistically. Whenever we change a test class that uses try!, we can remove it. We should enable the swiftlint rule to avoid having try! again in the future, once we ditched all of these.
I agree that we should tackle this and enable the swiftlint rule. Maybe it's worth splitting up the refactoring for tests and for SDK into two PRs, as one affects the changelog while the other doesn't
Description
Previously I've removed potential crashers in test code in #4125 and #4132, but I guess I didn't think to look for this. Just noticed it, and we currently have 69 instances. Most should be an easy conversion of the enclosing test cases to
throws
, but a few are property intializers on Fixture instances that will need a little more work to maybe change to optional types.The text was updated successfully, but these errors were encountered: