Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve debug upload output messages #1583

Closed
mattjohnsonpint opened this issue Apr 19, 2023 · 4 comments · Fixed by #1620
Closed

Improve debug upload output messages #1583

mattjohnsonpint opened this issue Apr 19, 2023 · 4 comments · Fixed by #1620

Comments

@mattjohnsonpint
Copy link
Contributor

When uploading a debug information file that is architecture-neutral, Sentry CLI emits unknown for the architecture name. This can make it appear that there is something wrong, especially when combined with the other flags.

For example, uploading files from a .NET 6 console application:

PENDING 5393add0-2afc-48f6-8015-1a3393695836-fa5c0a3f (Sentry.Samples.Console.Basic.pdb; unknown sources)
PENDING 239a9c2c-e55e-337e-aecd-054ae6806182 (apphost; arm64 executable)
PENDING 5393add0-2afc-48f6-8015-1a3393695836-fa5c0a3f (Sentry.Samples.Console.Basic.pdb; unknown debug companion)

The apphost shows correctly that this was an arm64 executable. But the other two are showing unknown sources (for the source bundle) and unknown debug companion for the symbols. This is confusing to the end-user. It would be better if the word unknown was simply omitted.

Additionally, PENDING is a confusing status to report, as it seems like there's still something to be done client-side. It would be less confusing and still accurate if it said SENT or UPLOADED, etc.

See also getsentry/sentry-dotnet#2307

Thanks.

@mattjohnsonpint
Copy link
Contributor Author

To clarify - .NET builds are architecture-neutral (and platform-neutral) by default. So "unknown" is the most common experience for our users. However, there are plenty of use cases where a specific platform or architecture is targeted. So if the PE/PDB has an architecture, it should still be displayed. Only omit it if it is "unknown".

@github-actions
Copy link

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@mattjohnsonpint
Copy link
Contributor Author

An update on this would be appreciated. Thanks.

@kamilogorek ?

@kamilogorek
Copy link
Contributor

Additionally, PENDING is a confusing status to report, as it seems like there's still something to be done client-side. It would be less confusing and still accurate if it said SENT or UPLOADED, etc.

Agree, especially that the message above states: "File upload complete".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants