-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable source context for non-release buildtype #661
Comments
hi @Shadowsx3 that's a good feature request, thank you! The reason we limited this to only release builds is to not regress build speed for debug builds, but having this configurable with a list of supported build types makes a lot of sense, we'll look into implementing this! |
Let's make this configurable:
|
As of now, the sentry AGP doesn't upload Source Context files if we use plugins like https://github.com/Triple-T/gradle-play-publisher. The task to build (and publish) an AAB using that plugin is Since the task mentioned above is not identified as an What's the recommended approach if we would like to force sentry AGP to run the Source Context related tasks for tasks other than assemble/bundle? |
Hey @RationalRank, thanks for the additional feedback! You could always run the upload task (e.g. |
Problem Statement
Currently by setting the includeSourceContext option to true, only the build type of release type automatically reports the source context during the assemble task.
It would be great if other custom build types could have the ability to report it automatically by enabling the option.
The documentation did not specify this detail and this change would be a great help in a variety of projects.
Solution Brainstorm
There are places in the code that even if you enable the option to do so, check that specifically the name of the build type is release. We could change that as in the following example and depend on the user configuration.
Example
The text was updated successfully, but these errors were encountered: