setup/bash: Handle pre-existing bash-preexec from other cli tools #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joshi4
commented
Aug 5, 2024
joshi4
commented
- cmd/init: separate bash-preexec and savvy setup
- setup/bash-hooks: Add funcs to only add shell hooks if required.
Savvy relies on bash-preexec.sh to setup pre_cmd and pre_exec hooks in bash. Users may rely on multiple other tools(atuin, starship, etc) that install and setup bash-preexec.sh. In such cases, a user's bashrc may initialize bash-preexec before running: `eval $(savvy init bash)` In that case [bash-preexec.sh](https://github.com/getsavvyinc/savvy-cli/blob/8c6a834c5a140b83cc77c788e40738f510af7c12/cmd/setup/bash-preexec.sh#L52) avoids duplicate inclusion and returns early. As a result, none of Savvy's custom hooks are evaluated and user's get an error messasge "not configured to use Savvy" when trying to record/run runbooks. This commit fixes the above issue by separating initializing bash-preexec from adding savvy's shell hooks. Fixes #118
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.