-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce internal commands to manage execution state #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joshi4
commented
Jun 13, 2024
- cmd/internal: setup internal cmds
- parse params
- server/client: Create client for any socket path
- server: DRY cleanup socket committed
- client: Add a shutdown interface
- server/run: Add a run server
- savvy.zsh: only use zle to trigger runner
- server/client: SendShutdown returns an err
- server/run: Update state based on commands
- server/run: Add client for run server
- cmd/run: use runServer to coordinate state
- server/run: disambiguate client struct from pkg
- cmd/internal: impl current and next
- change return data for next and current
- cmd/history: handle err starting record server
- run: start server
- server/run: read json messages instead of waiting for client to close the conn
- close client conn when done
- savvy.zsh: use internal commands to run runbooks
- cmd/next: return immediately if no prev command
- server/run: return val using json encoder
- server/run: allow idx == len(commands)
- debug: savvy.zsh display next
- add tests
- setup/savvy.zsh: use 0 based arrays everywhere except when displaying step count
- internal/next: return 0 based array idx
- server/run: rm debug logs
- setup/savvy.zsh: cleanup debug logs
- server/run: Add note about why the run server is single threaded
- cmd/setup/bash-preexec.sh: impl run hooks with savvy internal cmds
- cmd/write: dracula shows better on light terminals
We are adding a new server type called run to manage the state for running runbooks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.