From 4971d3e750deebf9702a7bcc0b1f83a8853f41f7 Mon Sep 17 00:00:00 2001 From: Daniel Lang Date: Sun, 25 Oct 2020 14:00:56 -0700 Subject: [PATCH 1/2] Fix counter visualization not working on Safari --- .../components/dashboards/dashboard-grid.less | 23 ++++++++----------- .../src/visualizations/counter/render.less | 1 - 2 files changed, 10 insertions(+), 14 deletions(-) diff --git a/client/app/components/dashboards/dashboard-grid.less b/client/app/components/dashboards/dashboard-grid.less index 2461b6aab3..f18fad7406 100644 --- a/client/app/components/dashboards/dashboard-grid.less +++ b/client/app/components/dashboards/dashboard-grid.less @@ -89,6 +89,7 @@ > .visualization-renderer-wrapper { flex-grow: 1; position: relative; + height: 0; } > .filters-wrapper { @@ -113,19 +114,15 @@ overflow: hidden; } - .counter-visualization-container { - height: 100%; - - .counter-visualization-content { - position: absolute; - left: 10px; - top: 15px; - right: 10px; - bottom: 15px; - height: auto; - overflow: hidden; - padding: 0; - } + .counter-visualization-content { + position: absolute; + left: 10px; + top: 15px; + right: 10px; + bottom: 15px; + height: auto; + overflow: hidden; + padding: 0; } } diff --git a/viz-lib/src/visualizations/counter/render.less b/viz-lib/src/visualizations/counter/render.less index db19ccb723..252d0c0242 100755 --- a/viz-lib/src/visualizations/counter/render.less +++ b/viz-lib/src/visualizations/counter/render.less @@ -3,7 +3,6 @@ text-align: center; padding: 15px 10px; overflow: hidden; - position: relative; .counter-visualization-content { margin: 0; From cf255ba4002aee826a9b0558e8cad2aa2c3a77f0 Mon Sep 17 00:00:00 2001 From: Daniel Lang Date: Sun, 25 Oct 2020 15:35:31 -0700 Subject: [PATCH 2/2] Fix counter visualization not working on Safari --- .../components/dashboards/dashboard-grid.less | 23 +++++++++++-------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/client/app/components/dashboards/dashboard-grid.less b/client/app/components/dashboards/dashboard-grid.less index f18fad7406..2461b6aab3 100644 --- a/client/app/components/dashboards/dashboard-grid.less +++ b/client/app/components/dashboards/dashboard-grid.less @@ -89,7 +89,6 @@ > .visualization-renderer-wrapper { flex-grow: 1; position: relative; - height: 0; } > .filters-wrapper { @@ -114,15 +113,19 @@ overflow: hidden; } - .counter-visualization-content { - position: absolute; - left: 10px; - top: 15px; - right: 10px; - bottom: 15px; - height: auto; - overflow: hidden; - padding: 0; + .counter-visualization-container { + height: 100%; + + .counter-visualization-content { + position: absolute; + left: 10px; + top: 15px; + right: 10px; + bottom: 15px; + height: auto; + overflow: hidden; + padding: 0; + } } }