Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special characters in Data Source passwords are not parsed correctly #4520

Open
Talon876 opened this issue Jan 3, 2020 · 2 comments
Open

Comments

@Talon876
Copy link

Talon876 commented Jan 3, 2020

Issue Summary

Data Sources cannot be used if the password contains special characters. If you escape the special characters in order to parse the password correctly, authentication fails as the characters are not unescaped.

This is true for Influx passwords and likely affects other Data Sources as well.

Steps to Reproduce

  1. Attempt to create a Data Source with a special character in the password section of the connection URI. E.g. https+influxdb://talon:passw/ord@myserver:8086/stats?ssl=true
  2. Save the Data Source
  3. Test the connection and note this error occurs:
Connection Test Failed:
invalid literal for int() with base 10: 'passw'

Technical details:

  • Redash Version: 8.0.0+b32245
  • Browser/OS: Chrome/MacOS
  • How did you install Redash: Docker
@kravets-levko
Copy link
Collaborator

kravets-levko commented Jan 3, 2020

Hi @Talon876! / is a sort of invalid character at that position, probably therefore URL is not parsed correctly. Could you try to URL-escape it (like this: https+influxdb://talon:passw%2Ford@myserver:8086/stats?ssl=true)?

@Talon876
Copy link
Author

Talon876 commented Jan 3, 2020

Thanks for the quick reply! I tried escaping the slash as you described which does seem to parse correctly. However, when I test the connection I am getting back 401: {"error":"authorization failed"} which I am guessing is because it's passing on the literal %2F in the password.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants