Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DynamicForm ignores default value for checkboxes #3486

Closed
arikfr opened this issue Feb 24, 2019 · 2 comments
Closed

DynamicForm ignores default value for checkboxes #3486

arikfr opened this issue Feb 24, 2019 · 2 comments
Assignees
@gabrieldutra
Labels
Bug Frontend

Comments

@arikfr
Copy link
Member

arikfr commented Feb 24, 2019

Issue Summary

Checkbox field might have a default value of true, it seems that DyanmicForm ignores this.

Steps to Reproduce

  1. Open new Data Source form of type BigQuery
  2. "Use Standard SQL" should be checked by default, but it isn't.

Technical details:

  • Redash Version: master
@gabrieldutra
Copy link
Member

Yep, it seems I've removed the whole setDefaults thing after a CR comment 😅. (ref). There were default values to inputs as well, but I guess the best for UX here will be to keep their default values as placeholders and treat checkboxes separately. WDYT?

@arikfr
Copy link
Member Author

arikfr commented Feb 24, 2019

but I guess the best for UX here will be to keep their default values as placeholders and treat checkboxes separately. WDYT?

👍

@gabrieldutra gabrieldutra mentioned this issue Feb 24, 2019
Merged
@ghost ghost added the in progress label Feb 24, 2019
@ghost ghost removed the in progress label Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabrieldutra gabrieldutra

Labels
Bug Frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arikfr @gabrieldutra