-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for custom working directory #61
Add support for custom working directory #61
Conversation
Signed-off-by: Thorsten Hans <thorsten.hans@gmail.com>
799adcf
to
7a8a362
Compare
I'm unclear whether we want this change even if/when we add changes to fix #16 . The changeset here looks good to me, if we wish to proceed with both. |
Now that we have built-in support for setting the working directory on a mixin, here's how a mixin can support this too:
|
@ThorstenHans now that it is possible to add support in this mixin for the standardized method of setting the working dir per step, do we still wish to add this functionality at the mixin config level? |
Obviously, the mixin should adopt the feature from porter instead of adding support for working directory by itself. |
Should I create a dedicated PR (for updating the porter dep) and add an example there or could I reuse this PR instead |
@ThorstenHans Although I might have a slight preference towards the creation of a new PR, I'll leave it up to you - whichever is most convenient. |
@vdice that's fine for me I'll close this one 👍 |
With this PR, users can specify a custom working directory for theit Terraform project.