Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot remove parameters in subsequent versions of bundles #2929

Closed
edespong opened this issue Sep 27, 2023 · 0 comments · Fixed by #3012
Closed

Cannot remove parameters in subsequent versions of bundles #2929

edespong opened this issue Sep 27, 2023 · 0 comments · Fixed by #3012
Labels
bug Oops, sorry!

Comments

@edespong
Copy link

edespong commented Sep 27, 2023

Describe the bug

If I have a bundle that takes a parameter in one version, it does not seem possible to upgrade to another version of the same bundle where the parameter has been deleted.

I see many scenarios where bundles need to evolve over time and remove parameters that are no longer needed/valid.

To Reproduce

Steps to reproduce the behavior:

  1. mkdir ~/param-bug

  2. porter create

  3. Edit porter.yaml to contain:
parameters:
  - name: testparam
    description: "A test param"
    type: string
    applyTo:
      - install
      - upgrade
  1. porter build

  2. porter install

  3. Modify porter.yaml again and bump the version to 0.2.0 and remove the parameters section added in step 3.
  4. porter build

  5. porter upgrade

Expected behavior

I would be able to perform an upgrade

Porter Command and Output

~/param-bug$ porter upgrade
could not apply options to installation: parameter testparam not defined in bundle
could not apply options to installation: parameter testparam not defined in bundle

Version

porter v1.0.14 (0e739d8)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Oops, sorry!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant