Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find invocation image in user facing text and replace with the term bundle image/container #1188

Closed
carolynvs opened this issue Jul 30, 2020 · 2 comments
Closed

Find invocation image in user facing text and replace with the term bundle image/container #1188

carolynvs opened this issue Jul 30, 2020 · 2 comments
Labels
2 - 🍕 Pizza should be eaten daily docs Markdown ahoy! Updates needed on porter.sh or in dev docs. good first issue Good for new contributors help wanted Good for someone who has contributed before hmm 🛑🤔 Needs more thinking time. Don't start on it yet, please.

Comments

@carolynvs
Copy link
Member

Everyone I talk to who encounters the term "invocation image" has an immediate negative confused reaction to the term. I think this is a term that maybe makes sense for CNAB but is something that Porter should abstract for its users.

I recommend that we use the term "installer" for user facing documentation and text, replacing any text in the CLI output or documentation. We already use that term when we set the invocationImage name e.g. bundlename-installer and it has worked well for people seeming to get it.
@carolynvs carolynvs added the suggestion Idea for maintainers to consider. Do not take this issue until triaged. label Jul 30, 2020
@carolynvs
Copy link
Member Author

Now that we don't even create an image at all that is distinct from the bundle for the invocation image, I think we can simplify this even further and replace "invocation image" with the bundle's image/container.

@carolynvs carolynvs added docs Markdown ahoy! Updates needed on porter.sh or in dev docs. 2 - 🍕 Pizza should be eaten daily and removed suggestion Idea for maintainers to consider. Do not take this issue until triaged. labels Mar 2, 2022
@carolynvs carolynvs modified the milestone: 1.0 Mar 2, 2022
@carolynvs carolynvs changed the title Find invocation image in user facing text and replace with the term installer Find invocation image in user facing text and replace with the term bundle image/container Mar 11, 2022
@carolynvs carolynvs mentioned this issue Mar 11, 2022
Closed
@schristoff schristoff added help wanted Good for someone who has contributed before good first issue Good for new contributors labels Jun 13, 2023
@schristoff schristoff mentioned this issue Jun 27, 2023
Closed
4 tasks
@schristoff schristoff moved this to 🆕 New in Porter Jul 28, 2023
@schristoff schristoff added the hmm 🛑🤔 Needs more thinking time. Don't start on it yet, please. label Jul 28, 2023
@kichristensen
Copy link
Contributor

Handled in #175

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Porter Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 - 🍕 Pizza should be eaten daily docs Markdown ahoy! Updates needed on porter.sh or in dev docs. good first issue Good for new contributors help wanted Good for someone who has contributed before hmm 🛑🤔 Needs more thinking time. Don't start on it yet, please.
Projects
Porter
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@carolynvs @kichristensen @schristoff