Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

while creating a dataset, the error informing about an invalid name of a dataset isn’t removed in the success dialog #624

Closed
dbemke opened this issue Apr 8, 2024 · 3 comments · Fixed by getodk/central-frontend#967
Assignees
Labels
behavior verified Behavior has been manually verified entities Multiple Encounter workflows frontend Requires a change to the UI

Comments

@dbemke
Copy link

dbemke commented Apr 8, 2024

Problem description

While creating a dataset manually via "+New” button, the error informing about an invalid name of a dataset isn’t removed in the success dialog (when a dataset has been created).

URL of the page

https://staging.getodk.cloud/

Steps to reproduce the problem

  1. Navigate to Entities Lists page.
  2. Click "+New” button.
  3. Enter an invalid dataset name (e.g. 1234).
  4. Click "Create”.
  5. Enter a valid name.
  6. Click "Create”.

Screenshot

errorSuccess

Expected behavior

The error should be removed after entering a valid name.

Central version shown in version.txt

https://staging.getodk.cloud/
versions:
f0b2a90 (v2023.5.1-5-gf0b2a90)
+2bb17a501416814bbd987ddc953abc5b0c40c58a client (v2023.5.0-43-g2bb17a50)
+267e0ad7806057fc82894f58bea680627f1de5cd server (v2023.5.0-49-g267e0ad7)

Browser version

Chrome and Firefox

@matthew-white
Copy link
Member

Interesting! I don't think we account for this in other multistep modals either, e.g., the "Create App User" modal. But I guess the "Create App User" modal has more limited backend validation compared to this new modal: there are more restrictions on the name of an entity list. @ktuite, I'm thinking that we could probably get away with just calling alert.blank() after incrementing step.value in DatasetNew.

@github-project-automation github-project-automation bot moved this to 🕒 backlog in ODK Central Apr 9, 2024
@matthew-white matthew-white added frontend Requires a change to the UI needs testing Needs manual testing entities Multiple Encounter workflows labels Apr 9, 2024
@ktuite ktuite moved this from 🕒 backlog to ✏️ in progress in ODK Central Apr 12, 2024
@github-project-automation github-project-automation bot moved this from ✏️ in progress to ✅ done in ODK Central Apr 15, 2024
@srujner
Copy link

srujner commented Apr 16, 2024

Tested with Success!

1 similar comment
@dbemke
Copy link
Author

dbemke commented Apr 16, 2024

Tested with Success!

@dbemke dbemke added behavior verified Behavior has been manually verified and removed needs testing Needs manual testing labels Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behavior verified Behavior has been manually verified entities Multiple Encounter workflows frontend Requires a change to the UI
Projects
Status: ✅ done
Development

Successfully merging a pull request may close this issue.

4 participants