Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

See upload as the origin of an Entity #583

Closed
matthew-white opened this issue Jan 11, 2024 · 10 comments · Fixed by getodk/central-frontend#949
Closed

See upload as the origin of an Entity #583

matthew-white opened this issue Jan 11, 2024 · 10 comments · Fixed by getodk/central-frontend#949
Assignees
Labels
backend Requires a change to the API server behavior verified Behavior has been manually verified enhancement New feature or behavior entities Multiple Encounter workflows frontend Requires a change to the UI

Comments

@matthew-white
Copy link
Member

See the story in the release criteria.

@matthew-white matthew-white added enhancement New feature or behavior backend Requires a change to the API server frontend Requires a change to the UI needs testing Needs manual testing needs design review Needs verification from designer entities Multiple Encounter workflows labels Jan 11, 2024
@github-project-automation github-project-automation bot moved this to 🕒 backlog in ODK Central Jan 11, 2024
@ktuite ktuite self-assigned this Feb 13, 2024
@ktuite ktuite moved this from 🕒 backlog to ✏️ in progress in ODK Central Feb 28, 2024
@ktuite ktuite linked a pull request Feb 28, 2024 that will close this issue
2 tasks
@github-project-automation github-project-automation bot moved this from ✏️ in progress to ✅ done in ODK Central Mar 5, 2024
@matthew-white
Copy link
Member Author

@getodk/testers, the code for this story is complete, but it's not easy to test it yet. I think we should probably wait to test this story until #589 is complete. Once you're able to upload entities in bulk, it'll be easier to verify whether you can see the upload as the origin of an entity. Currently the only way to upload in bulk is via the API.

@dbemke
Copy link

dbemke commented Mar 27, 2024

We tried uploading a list of 400-500 entities, also 2 users doing it at the same time and on Chrome when the list is loading there's "Page Unresponsive" . It happened 27.03.2024 around 3p.m. CET

Image

Steps to reproduce:

  1. Upload a file with entities e.g. https://test.getodk.cloud/#/projects/505/entity-lists/trees/entities

trees.csv
2. Scroll down the list of entities.

After that when I scroll up to see the top of the table there is only a table without any text (only "Conflict status").

Image

@dbemke
Copy link

dbemke commented Mar 27, 2024

While the list is loading there's info "Loading x more of y entities". Sometimes the number was 250 but once it was even 1000. Is there a specified number how many should load at once?

Image

@matthew-white
Copy link
Member Author

matthew-white commented Mar 27, 2024

Is there a specified number how many should load at once?

It starts out as 250, but once 1,000 have been loaded, it starts loading 1,000 each time.

After that when I scroll up to see the top of the table there is only a table without any text

I've seen something like this when I've loaded many rows of a table. I'm a little surprised though that there's an issue as early as ~3,000 rows. We're planning to replace the infinite scroll here with pagination, which should help a lot with this sort of issue. Pagination would show fewer rows on the page at once.

We tried uploading a list of 400-500 entities, also 2 users doing it at the same time and on Chrome when the list is loading there's "Page Unresponsive" .

This is probably a problem with the UI rather than the server, but I don't have many ideas about how to address it. 400–500 entities seems like a small number. I think the issue probably isn't related to there being two simultaneous users. Have you seen this issue before? Also, had you scrolled to the bottom of the table when this happened? Maybe like above, it's an issue with the UI trying to show too many rows at once.

@dbemke
Copy link

dbemke commented Mar 28, 2024

This is probably a problem with the UI rather than the server, but I don't have many ideas about how to address it. 400–500 entities seems like a small number. I think the issue probably isn't related to there being two simultaneous users. Have you seen this issue before? Also, had you scrolled to the bottom of the table when this happened? Maybe like above, it's an issue with the UI trying to show too many rows at once.

The first time it happened I just uploaded 400 entities and scrolled to the bottom of the table. So probably it's connected with scrolling. When we tried adding at the same time+ scrolling my browser (Chrome) froze and needed restarting.

@srujner
Copy link

srujner commented Apr 22, 2024

Tested with success!

1 similar comment
@dbemke
Copy link

dbemke commented Apr 22, 2024

Tested with success!

@dbemke dbemke added behavior verified Behavior has been manually verified and removed needs testing Needs manual testing labels Apr 22, 2024
@matthew-white
Copy link
Member Author

The first time it happened I just uploaded 400 entities and scrolled to the bottom of the table. So probably it's connected with scrolling. When we tried adding at the same time+ scrolling my browser (Chrome) froze and needed restarting.

Sorry @dbemke, I meant to ask more about this!

  • Has it happened again that there's "Page Unresponsive" or Chrome freezes?
  • Have you seen "Page Unresponsive" and/or Chrome freezing in the past? Or is it new?
  • Do you see this only after you upload entities, or does it happen other times when you scroll? What happens if you scroll down that page without uploading entities?

@dbemke
Copy link

dbemke commented Apr 26, 2024

The "page unresponsive" happened just once after uploading entities and I think it was the first and only time Chrome froze (to such extent). It happened while scrolling down a list of uploaded entities.
The part with the empty table (while scrolling) happens also in submissions tab.

@dbemke
Copy link

dbemke commented Apr 26, 2024

There was "page unresponsive" again but a short one. Steps in that case were:

  1. An entity list without any entities added.
  2. I clicked "Upload entities".
  3. I downloaded the template and created around 400 entities in the file.
  4. I uploaded the file.
  5. Scrolled down the page

@matthew-white matthew-white removed the needs design review Needs verification from designer label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Requires a change to the API server behavior verified Behavior has been manually verified enhancement New feature or behavior entities Multiple Encounter workflows frontend Requires a change to the UI
Projects
Status: ✅ done
Development

Successfully merging a pull request may close this issue.

4 participants