Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

placeholder attribute is not applied to textarea tags #10

Closed
z3cka opened this issue Oct 22, 2015 · 12 comments
Closed

placeholder attribute is not applied to textarea tags #10

z3cka opened this issue Oct 22, 2015 · 12 comments
Labels

Comments

@z3cka
Copy link

z3cka commented Oct 22, 2015

It seems that

- name: detailed-description
      label: Detailed description
      placeholder: 'including learning outcomes, for proposal review (up to 250 words)'
      type: textarea

outputs:

<textarea rows="10" class="form-control" name="detailed-description"></textarea>

missing the placeholder attribute

@rhukster
Copy link
Member

What version of form plugin are you running? I think this was fixed in 0.6.0.

@z3cka
Copy link
Author

z3cka commented Oct 22, 2015

v0.6.0 just updated with bin/gpm

@rhukster
Copy link
Member

Hmm. i'm not sure why.. it's clearly in the textarea.html.twig field file.

@z3cka
Copy link
Author

z3cka commented Oct 22, 2015

hmm... cleared cache but it looks like that template is not being used in my case... will dig deeper.

@rhukster
Copy link
Member

Make sure you don't still have this file in the admin plugin: /themes/grav/templates/forms/fields/textarea. It was removed some time ago, but it might not of removed those during an upgrade.

You can safely remove that textarea folder.. in fact these are the only ones you should have in there:

2015-10-22-16-rk5nc

@rhukster
Copy link
Member

Alternatively you can uninstall and then re-install the admin plugin

@z3cka
Copy link
Author

z3cka commented Oct 22, 2015

nope, no textarea folder there, strange

@z3cka
Copy link
Author

z3cka commented Oct 22, 2015

isn't there something in the grav debugger bar that will show all templates fired?

@rhukster
Copy link
Member

Used to be but Twig library removed the methods that it used, so it was taken out.

@rhukster
Copy link
Member

Just put some Text in the field, and see if that text is output, to see if its being used.

@z3cka
Copy link
Author

z3cka commented Oct 22, 2015

found it! /user/themes/bootstrap/templates/forms/fields/textarea/textarea.html.twig is the culprit!

Will move this issue to bootstrap theme project.

@z3cka z3cka closed this as completed Oct 22, 2015
@rhukster
Copy link
Member

Ah! Some of those were edited to have a bootstrap-friendly output, they are probably out of date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants