Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: kube-worker module created duplicate worker role #137

Merged
merged 1 commit into from
Dec 15, 2021
Merged

FIX: kube-worker module created duplicate worker role #137

merged 1 commit into from
Dec 15, 2021

Conversation

Downager
Copy link
Contributor

  • no longer create duplicate worker iam role when var.role_name is set.

@Downager Downager changed the title FIX: kube-worker module created duplicate worker role FIX: kube-worker module create duplicate worker role Nov 29, 2021
@Downager Downager changed the title FIX: kube-worker module create duplicate worker role FIX: kube-worker module created duplicate worker role Nov 29, 2021
@Downager Downager changed the title FIX: kube-worker module created duplicate worker role WIP: FIX: kube-worker module created duplicate worker role Nov 29, 2021
@Downager Downager changed the title WIP: FIX: kube-worker module created duplicate worker role FIX: kube-worker module created duplicate worker role Nov 30, 2021
smalltown
smalltown approved these changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@smalltown smalltown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Downager
Copy link
Contributor Author

Downager commented Dec 8, 2021

Circle CI 看起來死在 SG 清不掉，最近綁在 Lambda 上的 ENI 都要好久才會回收，連帶影響到相關 SG 移除時間拉長

@Downager Downager merged commit 2c17f86 into master Dec 15, 2021
@Downager Downager deleted the fix/duplicated-worker-role branch December 15, 2021 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smalltown smalltown smalltown approved these changes

@chechiachang chechiachang Awaiting requested review from chechiachang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Downager @smalltown