Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect connection URI format #72

Closed
rolznz opened this issue May 13, 2023 · 2 comments · Fixed by #105
Closed

Incorrect connection URI format #72

rolznz opened this issue May 13, 2023 · 2 comments · Fixed by #105
Assignees
@kiwiidb

Comments

@rolznz
Copy link
Contributor

rolznz commented May 13, 2023

It looks like nostr-wallet-connect is using nostrwalletconnect: rather than nostr+walletconnect: for the connection URI which doesn't match https://github.com/nostr-protocol/nips/blob/master/47.md
@bumi
Copy link
Contributor

bumi commented May 21, 2023

this is because of old integrations.
@kiwiidb can we update it now?

@bumi bumi added this to 🐝 Alby May 21, 2023
@bumi bumi moved this to 📝 To-Do in 🐝 Alby May 21, 2023
@im-adithya im-adithya mentioned this issue Jul 10, 2023
Merged
@im-adithya
Copy link
Member

Fixed in #105

@github-project-automation github-project-automation bot moved this from 📝 To-Do to ✅ Done in 🐝 Alby Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kiwiidb kiwiidb

Labels
None yet
Projects
🐝 Alby
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use new nostr+walletconnect URL format getAlby/nostr-wallet-connect
4 participants
@bumi @kiwiidb @rolznz @im-adithya