Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zaps fake confirmed & connections don't properly delete (NWC in Umbrel) #108

Closed
Freakoverse opened this issue Jul 11, 2023 · 3 comments · Fixed by #111
Closed

Zaps fake confirmed & connections don't properly delete (NWC in Umbrel) #108

Freakoverse opened this issue Jul 11, 2023 · 3 comments · Fixed by #111

Comments

@Freakoverse
Copy link

Installed the NWC in my Umbrel node, and I made a connection with Amethyst, though I don't have an LN channel set up, and yet I can still "Zap". It was also "confirmed" in the NWC app as shown in the "current usage", and in Ameythst as indicated by the increased number and highlighted zap icon (Amethyst dev notified), but nothing was actually sent of course. (Expected an error or something but it "went through".

The other issue:

If I disconnect a connection and create a new one, it saves the previous permissions and historical spending in current usage. It doesn't actually make a fresh connection aside from changing the app connection pubkey.

This would also apply to a second connection, a new second would have the old seconds permissions.

I'm assuming this follows for 3rd, 4th, etc.

@bumi
Copy link
Contributor

bumi commented Jul 14, 2023

Thanks for reporting.
That's a good point. The "last accessed" date currently does not check if it was successful or not. There have also been thoughts on showing a complete audit log that users can see every action and the outcome - What do you think about that?
And should last-accessed be the last access that lead to a payment?

It also seems that the clients often do not propagate the error to the user in the apps. Some implement it as fire-and-forget.

@kiwiidb
Copy link
Contributor

kiwiidb commented Jul 17, 2023

Hey @Freakoverse I've made a PR to fix the issue with deleting permissions, good catch.
However, I could not reproduce the zapping issue on Amethyst. Are you sure the zap didn't just go through?

@Freakoverse
Copy link
Author

Freakoverse commented Jul 17, 2023

Hey @Freakoverse I've made a PR to fix the issue with deleting permissions, good catch. However, I could not reproduce the zapping issue on Amethyst. Are you sure the zap didn't just go through?

Thanks!
I'm assuming the zapping issue with Amethyst is on Amethyst's side and has been fixed potentially. Here's the convo:
https://snort.social/e/note1euc4lms2dxay0av8vuzcd60aytsgpmlyh82cfcl7wh2420ccxexq0tnqhj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants