-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zaps fake confirmed & connections don't properly delete (NWC in Umbrel) #108
Comments
Thanks for reporting. It also seems that the clients often do not propagate the error to the user in the apps. Some implement it as fire-and-forget. |
Hey @Freakoverse I've made a PR to fix the issue with deleting permissions, good catch. |
Thanks! |
Installed the NWC in my Umbrel node, and I made a connection with Amethyst, though I don't have an LN channel set up, and yet I can still "Zap". It was also "confirmed" in the NWC app as shown in the "current usage", and in Ameythst as indicated by the increased number and highlighted zap icon (Amethyst dev notified), but nothing was actually sent of course. (Expected an error or something but it "went through".
The other issue:
If I disconnect a connection and create a new one, it saves the previous permissions and historical spending in current usage. It doesn't actually make a fresh connection aside from changing the app connection pubkey.
This would also apply to a second connection, a new second would have the old seconds permissions.
I'm assuming this follows for 3rd, 4th, etc.
The text was updated successfully, but these errors were encountered: