Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design new 1-click App Connection flow that works on all environments #328

Closed
rolznz opened this issue Jul 24, 2024 · 3 comments · Fixed by #1016
Closed

Design new 1-click App Connection flow that works on all environments #328

rolznz opened this issue Jul 24, 2024 · 3 comments · Fixed by #1016
Milestone

Comments

@rolznz
Copy link
Contributor

rolznz commented Jul 24, 2024

Try at https://paper-scissors-hodl.fly.dev/

On mobile this leaves the app connection completely broken - and copying the connection secret cannot work either because Alby Hub does not know it

Update: this cannot be fixed with nwc.getalby.com. We need to design a new 1-click app connection flow that works in all environments

@bumi
Copy link
Contributor

bumi commented Jul 24, 2024

we miss this event then:

// notify the opener if present of the success full connect
  window.addEventListener("load", (event) => {

    // dispatch a success event which can be listened to by the opener or by the app that embeddes the webview
    // this gives those apps the chance to know the user has enabled the connection
    const nwcEvent = new CustomEvent("nwc:success", { detail: {} });
    window.dispatchEvent(nwcEvent);

    // notify the opener of the successful connection
    if (window.opener) {
      window.opener.postMessage(
        {
          type: "nwc:success",
          payload: {success: true},
        },
        "*"
      );
    }
  });

@bumi
Copy link
Contributor

bumi commented Jul 24, 2024

@rolznz rolznz modified the milestones: v1.6.0, v1.7.0 Aug 13, 2024
@rolznz
Copy link
Contributor Author

rolznz commented Aug 13, 2024

We need to design a new 1-click app connection flow that works in all environments

@rolznz rolznz changed the title Deeplink from nwc.getalby.com does not automatically close after app connection is created Design new 1-click App Connection flow that works on all environments Aug 13, 2024
@rolznz rolznz modified the milestones: v1.7.0, v1.8.0 Aug 29, 2024
@rolznz rolznz modified the milestones: v1.8.0, v1.9.0 Sep 12, 2024
@rolznz rolznz modified the milestones: v1.11.0, v1.12.0 Sep 25, 2024
@rolznz rolznz modified the milestones: v1.12.0, v1.13.0 Oct 19, 2024
@rolznz rolznz modified the milestones: v1.16.0, v1.15.0 Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants