Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing items that match after update/patch #71

Merged
merged 3 commits into from
May 7, 2022
Merged

fix: missing items that match after update/patch #71

merged 3 commits into from
May 7, 2022

Conversation

mariusheine
Copy link
Member

No description provided.

@mariusheine mariusheine requested a review from lukashass May 6, 2022 20:53
@github-actions
Copy link

github-actions bot commented May 6, 2022 •
edited
Loading

Coverage report

Total coverage

Status Category Percentage Covered / Total
🟢 Statements 100% 125/125
🟢 Branches 100% 28/28
🟢 Functions 100% 30/30
🟢 Lines 100% 177/177

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 2d0f791

@mariusheine mariusheine requested a review from anbraten May 6, 2022 21:06
lukashass
lukashass reviewed May 7, 2022
View reviewed changes
@mariusheine @lukashass
simplify onItemChange handler
7a588a0 
Co-authored-by: Lukas <lukas@slucky.de>
@mariusheine mariusheine requested a review from lukashass May 7, 2022 15:41
anbraten
anbraten suggested changes May 7, 2022
View reviewed changes
Copy link
Contributor

@anbraten anbraten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a check to some existing test maybe behind line 514 to check that the changed item is still at the same position and not only contained in the array. That is quite important to prevent list from changing their orders after receiving an update.

@mariusheine
Copy link
Member Author

Could you add a check to some existing test maybe behind line 514 to check that the changed item is still at the same position and not only contained in the array. That is quite important to prevent list from changing their orders after receiving an update.

@anbraten I added a test. Please have a look

@mariusheine mariusheine requested a review from anbraten May 7, 2022 15:59
@anbraten anbraten added the bug Something isn't working label May 7, 2022
@anbraten anbraten merged commit b2bef6c into main May 7, 2022
@anbraten anbraten deleted the missing-changed-items-matching-query branch May 7, 2022 16:07
@github-actions
Copy link

github-actions bot commented May 7, 2022

🎉 This PR is included in version 3.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anbraten anbraten anbraten approved these changes

@lukashass lukashass Awaiting requested review from lukashass

Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mariusheine @anbraten @lukashass