Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review the query panel layout #1468

Closed
offtherailz opened this issue Feb 15, 2017 · 14 comments
Closed

Review the query panel layout #1468

offtherailz opened this issue Feb 15, 2017 · 14 comments

Comments

@offtherailz
Copy link
Member

The query panel should be refactored in terms of style and usability.

@allyoucanmap
Copy link
Contributor

here some possible changes

initial state

  • before
    03b

  • after
    00


with add condition

  • before
    02b

  • after
    01


with add group

  • before
    01b

  • after
    02

gif

  • after
    03

@simboss
Copy link
Member

simboss commented Feb 15, 2017

search & reset are in a different position now....

@allyoucanmap
Copy link
Contributor

this should be with search & reset in the right position:

initial state

  • before
    00d

  • after
    00c


with add condition

  • before
    01d

  • after
    01c


with add group

  • before
    02d

  • after
    02c

@allyoucanmap
Copy link
Contributor

we could integrate the query builder header with the back button

move

@offtherailz
Copy link
Member Author

I should use shadows instead of borders to highlight nested filters. Like this:
https://codepen.io/sdthornton/pen/wBZdXq

@allyoucanmap
Copy link
Contributor

I just tried it and box-shadow works better than borders,
it's cleaner than before

sha

@allyoucanmap
Copy link
Contributor

allyoucanmap commented Feb 16, 2017

here the scroll bar is only inside the body so the query builder header is static.

scroll

@offtherailz
Copy link
Member Author

many nested objects are still confusing. Maybe we can think about collapsing groups.
Can you show a real example? (1 level of nesting is enough)

@allyoucanmap
Copy link
Contributor

nested

@offtherailz
Copy link
Member Author

Almost there, but it is not clear what is doing yet...
What if we use cards even for the 1 row condition? And complex conditions should be collapsible.

@allyoucanmap
Copy link
Contributor

this is an update with card for every attribute filter group

00

01

@simboss
Copy link
Member

simboss commented Feb 17, 2017

much better...

@allyoucanmap
Copy link
Contributor

latest update

  • added bbox/circle panel style

6
5
4
3
2
1
0

@simboss
Copy link
Member

simboss commented Feb 19, 2017

I like it !

@ghost ghost added the pending review label Feb 22, 2017
@mbarto mbarto closed this as completed in ba1ed63 Feb 22, 2017
@ghost ghost assigned mbarto Feb 22, 2017
@ghost ghost removed the pending review label Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants