-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Legend filter is persisted while editing a style causing inconsistencies #10236
Comments
Here what we internally agreed for this enhancement:
In all these cases:
In this case, when the legend is expanded, MS performs the requests to fetch the legend JSON. Contextually MS can compare the available filter item of the legend present in the response with the existing one in the layer state. In case of diffs detected, am inline warning is displayed to the user informing about that with a button to reset the legend state and align it to the new one. |
Description
The legend filter is not removed while editing a style of a WMS layer with the visual style editor, this can cause incosistency in the following cases:
For all the internal editing we should intercept the events and correctly update the layer (it could be helpfull to take a look to the styleeditor epic where all the style editor logic is implemented).
For external cases I think we need a message inside the Legend component itself to let the user know that something is not aligned and a button to reset the legend filters
Important: the legend filter is part of the
layerFilter
that could have similar inconsistency problems so it's important to evaluate this task taking into account the whole propertyWhat kind of improvement you want to add? (check one with "x", remove the others)
Other useful information
The text was updated successfully, but these errors were encountered: