Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in example Forward Pass of Transformer With Tabular Models) #19

Closed
maxlchen opened this issue Apr 13, 2022 · 0 comments · Fixed by #31
Closed

Typo in example Forward Pass of Transformer With Tabular Models) #19

maxlchen opened this issue Apr 13, 2022 · 0 comments · Fixed by #31

Comments

@maxlchen
Copy link

I believe there is a typo under docs/source/notes/introduction.rst on line 98.

model_inputs['num_feats'] = numerical_feat

should be

model_inputs['numerical_feats'] = numerical_feat

if we are not explicitly specifying the features in the forward pass. The forward pass defined for the Tabular models takes a numerical_feats parameter, not num_feats. So in the example given, it would compute the forward pass with None for the numeric features.

Longer snippet from introduction.rst below:

model_inputs['cat_feats'] = categorical_feat
model_inputs['num_feats'] = numerical_feat
model_inputs['labels'] = labels

loss, logits, layer_outs = model(**model_inputs)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant