Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit mismatch in FileSizeExceeded error_message #571

Closed
1 of 8 tasks
huard opened this issue Feb 3, 2021 · 3 comments
Closed
1 of 8 tasks

Unit mismatch in FileSizeExceeded error_message #571

huard opened this issue Feb 3, 2021 · 3 comments
Assignees
Labels

Comments

@huard
Copy link
Collaborator

huard commented Feb 3, 2021

Description

The file property of the URLHandler object checks if the data size is larger than the maximum data size. When it exceeds the maximum value, it raises an error:

error_message = 'File size for input "{}" exceeded. Maximum allowed: {} megabytes'.format(

The value is in units of bytes, but the message says megabytes.

Also, it would be useful if the message included the actual size of the data.

Environment

  • operating system:
  • Python version: 3.8
  • PyWPS version:4.2.9
  • source/distribution
  • git clone
  • Debian
  • PyPI
  • zip/tar.gz
  • other (please specify):
  • web server
  • Apache/mod_wsgi
  • CGI
  • other (please specify):

Steps to Reproduce

Additional Information

@huard
Copy link
Collaborator Author

huard commented Feb 3, 2021

Also, why is the FileSizeExceeded exception in the try statement replaced by NoApplicableCode?

@cehbrecht cehbrecht added the bug label Feb 8, 2021
@cehbrecht
Copy link
Collaborator

I run into the same issue:
roocs/rook#139 (comment)

@cehbrecht cehbrecht self-assigned this Mar 12, 2021
@cehbrecht
Copy link
Collaborator

should be fixed by PRs #580 and #581.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants